Move and rename legacy elasticsearch client #69797

pgayvallet · 2020-06-24T12:32:09Z

Summary

move all the legacy client related stuff to its own legacy subfolder
prefix all legacy client's types and classes with Legacy
adapt all imports/usages in plugins code.

To code owners (this is not a failed rebase)

This is only a preliminary renaming in preparation of the introduction of the new elasticsearch client. Even if it did impact a lot of files, nothing functional nor technical was altered in this PR.

Checklist

Documentation was added for features that require explanation or tutorials

…gacy-es-client

elasticmachine · 2020-06-25T08:30:00Z

Pinging @elastic/kibana-platform (Team:Platform)

skh

👍 from @elastic/ingest-management. Looking forward to using the new client!

sorenlouv

apm changes lgtm

walterra

ML/Transform changes LGTM.

azasypkin

Changes in Security/Spaces LGTM (code review only).

mikecote

Alerting related code LGTM

chrisronline

LGTM for Stack Monitoring

flash1293

Kibana app changes LGTM, code review only

afharo

Telemetry changes LGTM! Pretty much just renaming the imported types to the new Legacy-prefixed names 👍

cjcenizal

ES UI code LGTM. Didn't test locally.

streamich

In AppArch codebase only a naming change, which LGTM.

jgowdyelastic

ML and Transform changes LGTM

mshustov

ok for platform changes

shahzad31

Uptime changes LGTM !!

oatkiller

Thanks!

…gacy-es-client

patrykkopycinski

Thank you @pgayvallet !

…gacy-es-client

kibanamachine · 2020-06-29T15:27:03Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: bea1eae

Build metrics

page load asset size

beta

id	value	diff	baseline
/bundles/app/core/bootstrap.js	-	-13.9KB	13.9KB
/bundles/core/core.entry.js	-	-1.1MB	1.1MB
/bundles/kbn-ui-shared-deps/[email protected]	-	-4.0MB	4.0MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.css	-	-183.7KB	183.7KB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js	-	-4.6MB	4.6MB
/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.v7.light.css	-	-511.3KB	511.3KB
/bundles/light_theme.style.css	-	-95.9KB	95.9KB
/bundles/plugin/advancedSettings/advancedSettings.plugin.js	-	-941.3KB	941.3KB
/bundles/plugin/alerts/alerts.plugin.js	-	-89.5KB	89.5KB
/bundles/plugin/apm/apm.plugin.js	-	-219.2KB	219.2KB
/bundles/plugin/apmOss/apmOss.plugin.js	-	-4.2KB	4.2KB
/bundles/plugin/beats_management/beats_management.plugin.js	-	-522.9KB	522.9KB
/bundles/plugin/bfetch/bfetch.plugin.js	-	-28.7KB	28.7KB
/bundles/plugin/canvas/canvas.plugin.js	-	-2.0MB	2.0MB
/bundles/plugin/charts/charts.plugin.js	-	-833.9KB	833.9KB
/bundles/plugin/cloud/cloud.plugin.js	-	-6.2KB	6.2KB
/bundles/plugin/console/console.plugin.js	-	-28.0KB	28.0KB
/bundles/plugin/crossClusterReplication/crossClusterReplication.plugin.js	-	-152.3KB	152.3KB
/bundles/plugin/dashboard/dashboard.plugin.js	-	-634.2KB	634.2KB
/bundles/plugin/dashboardEnhanced/dashboardEnhanced.plugin.js	-	-143.5KB	143.5KB
/bundles/plugin/dashboardMode/dashboardMode.plugin.js	-	-109.3KB	109.3KB
/bundles/plugin/data/data.plugin.js	-	-1.3MB	1.3MB
/bundles/plugin/dataEnhanced/dataEnhanced.plugin.js	-	-138.1KB	138.1KB
/bundles/plugin/devTools/devTools.plugin.js	-	-123.9KB	123.9KB
/bundles/plugin/discover/discover.plugin.js	-	-221.5KB	221.5KB
/bundles/plugin/discoverEnhanced/discoverEnhanced.plugin.js	-	-28.1KB	28.1KB
/bundles/plugin/embeddable/embeddable.plugin.js	-	-390.9KB	390.9KB
/bundles/plugin/embeddableEnhanced/embeddableEnhanced.plugin.js	-	-26.3KB	26.3KB
/bundles/plugin/esUiShared/esUiShared.plugin.js	-	-927.8KB	927.8KB
/bundles/plugin/expressions/expressions.plugin.js	-	-314.9KB	314.9KB
/bundles/plugin/features/features.plugin.js	-	-13.4KB	13.4KB
/bundles/plugin/fileUpload/fileUpload.plugin.js	-	-688.0KB	688.0KB
/bundles/plugin/globalSearch/globalSearch.plugin.js	-	-29.0KB	29.0KB
/bundles/plugin/globalSearchProviders/globalSearchProviders.plugin.js	-	-9.7KB	9.7KB
/bundles/plugin/graph/graph.plugin.js	-	-15.3KB	15.3KB
/bundles/plugin/grokdebugger/grokdebugger.plugin.js	-	-11.2KB	11.2KB
/bundles/plugin/home/home.plugin.js	-	-24.6KB	24.6KB
/bundles/plugin/indexLifecycleManagement/indexLifecycleManagement.plugin.js	-	-184.2KB	184.2KB
/bundles/plugin/indexManagement/indexManagement.plugin.js	-	-201.7KB	201.7KB
/bundles/plugin/indexPatternManagement/indexPatternManagement.plugin.js	-	-137.3KB	137.3KB
/bundles/plugin/infra/infra.plugin.js	-	-92.9KB	92.9KB
/bundles/plugin/ingestPipelines/ingestPipelines.plugin.js	-	-30.8KB	30.8KB
/bundles/plugin/inputControlVis/inputControlVis.plugin.js	-	-258.9KB	258.9KB
/bundles/plugin/inspector/inspector.plugin.js	-	-238.3KB	238.3KB
/bundles/plugin/kibanaLegacy/kibanaLegacy.plugin.js	-	-174.7KB	174.7KB
/bundles/plugin/kibanaReact/kibanaReact.plugin.js	-	-575.3KB	575.3KB
/bundles/plugin/kibanaUtils/kibanaUtils.plugin.js	-	-434.4KB	434.4KB
/bundles/plugin/lens/lens.plugin.js	-	-758.3KB	758.3KB
/bundles/plugin/licenseManagement/licenseManagement.plugin.js	-	-25.8KB	25.8KB
/bundles/plugin/licensing/licensing.plugin.js	-	-21.6KB	21.6KB
/bundles/plugin/logstash/logstash.plugin.js	-	-141.8KB	141.8KB
/bundles/plugin/management/management.plugin.js	-	-25.9KB	25.9KB
/bundles/plugin/maps/maps.plugin.js	-	-220.6KB	220.6KB
/bundles/plugin/mapsLegacy/mapsLegacy.plugin.js	-	-1.0MB	1.0MB
/bundles/plugin/mapsLegacyLicensing/mapsLegacyLicensing.plugin.js	-	-3.9KB	3.9KB
/bundles/plugin/ml/ml.plugin.js	-	-1.3MB	1.3MB
/bundles/plugin/monitoring/monitoring.plugin.js	-	-22.8KB	22.8KB
/bundles/plugin/navigation/navigation.plugin.js	-	-122.2KB	122.2KB
/bundles/plugin/newsfeed/newsfeed.plugin.js	-	-22.7KB	22.7KB
/bundles/plugin/observability/observability.plugin.js	-	-103.1KB	103.1KB
/bundles/plugin/painlessLab/painlessLab.plugin.js	-	-158.8KB	158.8KB
/bundles/plugin/regionMap/regionMap.plugin.js	-	-791.7KB	791.7KB
/bundles/plugin/remoteClusters/remoteClusters.plugin.js	-	-35.2KB	35.2KB
/bundles/plugin/reporting/reporting.plugin.js	-	-257.7KB	257.7KB
/bundles/plugin/rollup/rollup.plugin.js	-	-186.0KB	186.0KB
/bundles/plugin/savedObjects/savedObjects.plugin.js	-	-196.2KB	196.2KB
/bundles/plugin/savedObjectsManagement/savedObjectsManagement.plugin.js	-	-176.6KB	176.6KB
/bundles/plugin/searchprofiler/searchprofiler.plugin.js	-	-42.8KB	42.8KB
/bundles/plugin/security/security.plugin.js	-	-248.0KB	248.0KB
/bundles/plugin/share/share.plugin.js	-	-80.5KB	80.5KB
/bundles/plugin/snapshotRestore/snapshotRestore.plugin.js	-	-57.5KB	57.5KB
/bundles/plugin/spaces/spaces.plugin.js	-	-367.2KB	367.2KB
/bundles/plugin/statusPage/statusPage.plugin.js	-	-3.6KB	3.6KB
/bundles/plugin/telemetry/telemetry.plugin.js	-	-77.0KB	77.0KB
/bundles/plugin/telemetryManagementSection/telemetryManagementSection.plugin.js	-	-27.5KB	27.5KB
/bundles/plugin/tileMap/tileMap.plugin.js	-	-807.1KB	807.1KB
/bundles/plugin/transform/transform.plugin.js	-	-21.6KB	21.6KB
/bundles/plugin/triggers_actions_ui/triggers_actions_ui.plugin.js	-	-103.0KB	103.0KB
/bundles/plugin/uiActions/uiActions.plugin.js	-	-162.5KB	162.5KB
/bundles/plugin/uiActionsEnhanced/uiActionsEnhanced.plugin.js	-	-130.7KB	130.7KB
/bundles/plugin/upgradeAssistant/upgradeAssistant.plugin.js	-	-46.6KB	46.6KB
/bundles/plugin/uptime/uptime.plugin.js	-	-327.3KB	327.3KB
/bundles/plugin/usageCollection/usageCollection.plugin.js	-	-24.4KB	24.4KB
/bundles/plugin/visTypeMarkdown/visTypeMarkdown.plugin.js	-	-512.5KB	512.5KB
/bundles/plugin/visTypeMetric/visTypeMetric.plugin.js	-	-536.7KB	536.7KB
/bundles/plugin/visTypeTable/visTypeTable.plugin.js	-	-563.0KB	563.0KB
/bundles/plugin/visTypeTagcloud/visTypeTagcloud.plugin.js	-	-797.1KB	797.1KB
/bundles/plugin/visTypeTimelion/visTypeTimelion.plugin.js	-	-670.7KB	670.7KB
/bundles/plugin/visTypeTimeseries/visTypeTimeseries.plugin.js	-	-212.2KB	212.2KB
/bundles/plugin/visTypeVega/visTypeVega.plugin.js	-	-580.3KB	580.3KB
/bundles/plugin/visTypeVislib/visTypeVislib.plugin.js	-	-1.2MB	1.2MB
/bundles/plugin/visualizations/visualizations.plugin.js	-	-343.4KB	343.4KB
/bundles/plugin/visualize/visualize.plugin.js	-	-18.2KB	18.2KB
/bundles/plugin/watcher/watcher.plugin.js	-	-35.2KB	35.2KB
/node_modules/@kbn/ui-framework/dist/kui_light.css	-	-62.1KB	62.1KB
/translations/en.json	-	-29.0B	29.0B
/ui/fonts/inter_ui/Inter-UI-Medium.woff2	-	-92.2KB	92.2KB
/ui/fonts/inter_ui/Inter-UI-Regular.woff2	-	-86.4KB	86.4KB
total	-	-36.2MB	-

History

💚 Build #56187 succeeded d7b4744
💔 Build #56024 failed b580083
💔 Build #55914 failed 8e88be7
💔 Build #55884 failed 9fef54d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* move last snapshot to inline * move legacy files to legacy subfolder * move request types out of legacy * export Headers from http instead of elasticsearch * renaming - first pass * renaming - second pass * fix core mocks * adapt new calls * update generated doc * fix IT test mocks * fix new usages # Conflicts: # src/core/server/saved_objects/service/lib/repository.ts # x-pack/plugins/event_log/server/es/context.test.ts # x-pack/plugins/oss_telemetry/server/test_utils/index.ts # x-pack/plugins/upgrade_assistant/server/lib/es_migration_apis.ts

* Move and rename legacy elasticsearch client (#69797) * move last snapshot to inline * move legacy files to legacy subfolder * move request types out of legacy * export Headers from http instead of elasticsearch * renaming - first pass * renaming - second pass * fix core mocks * adapt new calls * update generated doc * fix IT test mocks * fix new usages # Conflicts: # src/core/server/saved_objects/service/lib/repository.ts # x-pack/plugins/event_log/server/es/context.test.ts # x-pack/plugins/oss_telemetry/server/test_utils/index.ts # x-pack/plugins/upgrade_assistant/server/lib/es_migration_apis.ts * fix usages

* move last snapshot to inline * move legacy files to legacy subfolder * move request types out of legacy * export Headers from http instead of elasticsearch * renaming - first pass * renaming - second pass * fix core mocks * adapt new calls * update generated doc * fix IT test mocks * fix new usages

pgayvallet added 4 commits June 24, 2020 13:09

move last snapshot to inline

1011bdf

move legacy files to legacy subfolder

ab0cfc2

move request types out of legacy

c829018

export Headers from http instead of elasticsearch

9fef54d

epixa mentioned this pull request Jun 24, 2020

Use new elasticsearch-js client in Elasticsearch service #35508

Closed

14 tasks

pgayvallet added 8 commits June 24, 2020 14:55

renaming - first pass

4188faa

renaming - second pass

5a1d39a

fix core mocks

8e88be7

Merge remote-tracking branch 'upstream/master' into kbn-35508-move-le…

7586279

…gacy-es-client

adapt new calls

ab51fd7

update generated doc

b580083

fix IT test mocks

6281c81

Merge remote-tracking branch 'upstream/master' into kbn-35508-move-le…

d7b4744

…gacy-es-client

pgayvallet marked this pull request as ready for review June 25, 2020 08:28

pgayvallet requested review from a team as code owners June 25, 2020 08:28

pgayvallet requested a review from a team June 25, 2020 08:28

pgayvallet requested review from a team as code owners June 25, 2020 08:28

pgayvallet requested a review from a team June 25, 2020 08:28

pgayvallet requested review from a team as code owners June 25, 2020 08:28

pgayvallet requested a review from a team June 25, 2020 08:28

pgayvallet requested a review from a team as a code owner June 25, 2020 08:28

botelastic bot added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jun 25, 2020

pgayvallet added v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jun 25, 2020

skh approved these changes Jun 25, 2020

View reviewed changes

sorenlouv approved these changes Jun 25, 2020

View reviewed changes

walterra approved these changes Jun 25, 2020

View reviewed changes

azasypkin approved these changes Jun 25, 2020

View reviewed changes

mikecote approved these changes Jun 25, 2020

View reviewed changes

chrisronline approved these changes Jun 25, 2020

View reviewed changes

flash1293 approved these changes Jun 25, 2020

View reviewed changes

afharo approved these changes Jun 25, 2020

View reviewed changes

cjcenizal approved these changes Jun 25, 2020

View reviewed changes

streamich approved these changes Jun 26, 2020

View reviewed changes

jgowdyelastic approved these changes Jun 26, 2020

View reviewed changes

mshustov approved these changes Jun 26, 2020

View reviewed changes

shahzad31 approved these changes Jun 26, 2020

View reviewed changes

oatkiller approved these changes Jun 26, 2020

View reviewed changes

pgayvallet added 2 commits June 29, 2020 09:31

Merge remote-tracking branch 'upstream/master' into kbn-35508-move-le…

f3fbff9

…gacy-es-client

fix new usages

16195fd

patrykkopycinski approved these changes Jun 29, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into kbn-35508-move-le…

bea1eae

…gacy-es-client

pgayvallet merged commit fe1c508 into elastic:master Jun 29, 2020

pgayvallet mentioned this pull request Jun 29, 2020

[7.x] Move and rename legacy elasticsearch client (#69797) #70221

Merged

pgayvallet mentioned this pull request Jul 1, 2020

Add new elasticsearch client #69905

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move and rename legacy elasticsearch client #69797

Move and rename legacy elasticsearch client #69797

pgayvallet commented Jun 24, 2020 •

edited

Loading

elasticmachine commented Jun 25, 2020

skh left a comment

sorenlouv left a comment

walterra left a comment

azasypkin left a comment

mikecote left a comment

chrisronline left a comment

flash1293 left a comment

afharo left a comment

cjcenizal left a comment

streamich left a comment

jgowdyelastic left a comment

mshustov left a comment

shahzad31 left a comment

oatkiller left a comment

patrykkopycinski left a comment

kibanamachine commented Jun 29, 2020

Move and rename legacy elasticsearch client #69797

Move and rename legacy elasticsearch client #69797

Conversation

pgayvallet commented Jun 24, 2020 • edited Loading

Summary

To code owners (this is not a failed rebase)

Checklist

elasticmachine commented Jun 25, 2020

skh left a comment

Choose a reason for hiding this comment

sorenlouv left a comment

Choose a reason for hiding this comment

walterra left a comment

Choose a reason for hiding this comment

azasypkin left a comment

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

chrisronline left a comment

Choose a reason for hiding this comment

flash1293 left a comment

Choose a reason for hiding this comment

afharo left a comment

Choose a reason for hiding this comment

cjcenizal left a comment

Choose a reason for hiding this comment

streamich left a comment

Choose a reason for hiding this comment

jgowdyelastic left a comment

Choose a reason for hiding this comment

mshustov left a comment

Choose a reason for hiding this comment

shahzad31 left a comment

Choose a reason for hiding this comment

oatkiller left a comment

Choose a reason for hiding this comment

patrykkopycinski left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 29, 2020

💚 Build Succeeded

Build metrics

page load asset size

History

pgayvallet commented Jun 24, 2020 •

edited

Loading