[WIP] Move UsageCollection plugin to a Core Service #69306
Conversation
afharo
added
Team:Core
afharo
force-pushed
the
move-usage-collection-to-core
branch
from
6bea618 to
a0f4a60
Compare
…ide (still plugin)
| export { | ||
| CollectorOptions as UsageCollectionCollectorOptions, | ||
| CollectorFormatForBulkUpload as UsageCollectionCollectorFormatForBulkUpload, | ||
| Collector as UsageCollectionCollector, | ||
| Purify as UsageCollectionPurify, | ||
| UsageCollector as UsageCollectionUsageCollector, | ||
| MakeSchemaFrom as UsageCollectionMakeSchemaFrom, | ||
| AllowedSchemaTypes as UsageCollectionAllowedSchemaTypes, | ||
| } from './collectors'; |
There was a problem hiding this comment.
Renaming all interfaces when exposing them publicly to match the prefix-pattern in core.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "id": "usageCollection", | |||
| "configPath": ["usageCollection"], | |||
| "configPath": ["usageCollection.uiMetric"], | |||
There was a problem hiding this comment.
Doing this because the config "usageCollection" is already registered by core. We are extending only the config re uiMetric for the public-end code
| maximumWaitTimeForAllCollectorsInS: schema.number({ | ||
| defaultValue: DEFAULT_MAXIMUM_WAIT_TIME_FOR_ALL_COLLECTORS_IN_S, | ||
| }), | ||
| enabled: schema.boolean({ defaultValue: true }), |
There was a problem hiding this comment.
There is the risk that disabling uiMetric, we'll disable this entire plugin (the core service would still be there though)?
| Collector, | ||
| } from './collector'; | ||
| export { UsageCollectionSetup } from './plugin'; | ||
| UsageCollectionPluginSetup as UsageCollectionSetup, |
There was a problem hiding this comment.
Using UsageCollectionPluginSetup because it has the @deprecated flag, encouraging to move to the core service.
💔 Build Failed
Failed CI StepsBuild metrics
History
To update your PR or re-run it, just comment with: |
|
No longer needed. Core will expose a telemetry-only API as suggested here |
|
Closing it in favour of the approach discussed in #56762 (comment) |
Summary
Related to #70779.
This is WIP to move the current UsageCollection plugin and convert it into a Core service.
TODOs:
ui_metricandapplication_usagelogics to core?There is a tight dependency to the
@kbn/analyticsreporter. We might want to revisit it to keep it split in the plugins 👀Checklist
Delete any items that are not applicable to this PR.
For maintainers