Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Updates Cypress README.md to show how to run-as-ci with Cypress UI [skip ci] #68728

Merged
merged 2 commits into from
Jun 10, 2020
Merged

[Security] Updates Cypress README.md to show how to run-as-ci with Cypress UI [skip ci] #68728

merged 2 commits into from
Jun 10, 2020

Conversation

spong
Copy link
Member

@spong spong commented Jun 10, 2020

Summary

Updates Cypress README.md to show how to run-as-ci with the Cypress UI.

Updates:

Note: To run-as-ci with the Cypress UI, update x-pack/test/security_solution_cypress/runner.ts from

args: ['cypress:run'],

to

args: ['cypress:open'],

This is helpful for debugging specific failed tests from CI without having to run the entire suite.

@spong spong added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 10, 2020
@spong spong requested a review from MadameSheema June 10, 2020 00:03
@spong spong requested review from a team as code owners June 10, 2020 00:03
@spong spong self-assigned this Jun 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

MadameSheema
MadameSheema approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@MadameSheema MadameSheema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @spong! I just added a suggestion 😊

@spong @MadameSheema
Feedback from comments
764793e 
Co-authored-by: MadameSheema <[email protected]>
@spong spong merged commit 3b4fa6a into master Jun 10, 2020
@spong spong deleted the update-cypress-readme-for-ci branch June 10, 2020 15:19
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 68728 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 12, 2020
@spong spong mentioned this pull request Jun 12, 2020
Merged
spong added a commit to spong/kibana that referenced this pull request Jun 12, 2020
@spong
[Security] Updates Cypress README.md to show how to run-as-ci with Cy…
5574e79 
…press UI [skip ci] (elastic#68728)

## Summary

Updates Cypress README.md to show how to `run-as-ci` with the Cypress UI. 

##### Updates: 
> Note: To `run-as-ci` with the Cypress UI, update [x-pack/test/security_solution_cypress/runner.ts](https://github.com/elastic/kibana/blob/master/x-pack/test/security_solution_cypress/runner.ts#L25) from 
> ``` ts
>args: ['cypress:run'],
>```
>to 
>``` ts
>args: ['cypress:open'],
>```
>This is helpful for debugging specific failed tests from CI without having to run the entire suite.
spong added a commit that referenced this pull request Jun 12, 2020
@spong
[Security] Updates Cypress README.md to show how to run-as-ci with Cy…
9aa7680 
…press UI [skip ci] (#68728) (#69040)

## Summary

Updates Cypress README.md to show how to `run-as-ci` with the Cypress UI. 

##### Updates: 
> Note: To `run-as-ci` with the Cypress UI, update [x-pack/test/security_solution_cypress/runner.ts](https://github.com/elastic/kibana/blob/master/x-pack/test/security_solution_cypress/runner.ts#L25) from 
> ``` ts
>args: ['cypress:run'],
>```
>to 
>``` ts
>args: ['cypress:open'],
>```
>This is helpful for debugging specific failed tests from CI without having to run the entire suite.
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jun 12, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadameSheema MadameSheema MadameSheema approved these changes

Assignees

@spong spong

Labels
release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spong @elasticmachine @kibanamachine @MadameSheema @MindyRS