Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Allow filters without index #68225

Merged
merged 3 commits into from
Jun 4, 2020
Merged

[FIX] Allow filters without index #68225

merged 3 commits into from
Jun 4, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Jun 4, 2020 •
edited
Loading

Summary

Follow up to #66979

Allow filters without index, skipping their validation, per request from SIEM.
Added test to cover case.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom requested a review from a team as a code owner June 4, 2020 09:12
@lizozom lizozom self-assigned this Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom added the release_note:skip Skip the PR/issue when compiling release notes label Jun 4, 2020
patrykkopycinski
patrykkopycinski approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@patrykkopycinski patrykkopycinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you

@Dosant
Copy link
Contributor

Dosant commented Jun 4, 2020

Tested by removing index pattern from filter: LGTM
Checked that filter is still showing as expected if filter field exists, but is showing warning if field not exists in current data.

@patrykkopycinski patrykkopycinski force-pushed the fix/allow-filters-without-index branch from f82bce5 to 42b0ad5 Compare June 4, 2020 15:49
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit 537d2f2 into elastic:master Jun 4, 2020
lizozom added a commit to lizozom/kibana that referenced this pull request Jun 5, 2020
@lizozom
[FIX] Allow filters without index (elastic#68225)
6bddc0f 
* Allow filters without index

* Explicitly return true from isFilterApplicable id no index patterns were provided

* Adjust test result
@lizozom lizozom mentioned this pull request Jun 5, 2020
Merged
lizozom added a commit that referenced this pull request Jun 5, 2020
@lizozom
[FIX] Allow filters without index (#68225) (#68349)
df3821c 
* Allow filters without index

* Explicitly return true from isFilterApplicable id no index patterns were provided

* Adjust test result
@Dosant Dosant mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrykkopycinski patrykkopycinski patrykkopycinski approved these changes

@Dosant Dosant Dosant approved these changes

Assignees

@lizozom lizozom

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lizozom @elasticmachine @Dosant @kibanamachine @patrykkopycinski