-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Add preview feature for metric threshold alerts #67684
Merged
Merged
Changes from 12 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
046a043
Add alert preview backend for threshold
Zacqary afa14e7
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary fb59bce
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary d06ed28
Get frontend and backend working
Zacqary 5a35520
i18n fix
Zacqary a09e7f5
Add hook for inventory preview
Zacqary 59e9bcd
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary 83516a2
Merge branch 'master' into 65830-alert-preview
elasticmachine 8dd5dd9
Remove breaking Boom import
Zacqary 48861b1
Merge branch '65830-alert-preview' of github.com:Zacqary/kibana into …
Zacqary 31c2708
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary e7406ef
Fix module import
Zacqary 2e908fc
Move types to common folder, rename metric query file
Zacqary 73400ea
Add too many buckets error r handler
Zacqary 0e4732f
Switch to evaluating based on the alert interval
Zacqary 925d01d
Add interval prompt to not enough data message
Zacqary 7e3a20a
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary a04ddde
Fix type check
Zacqary 6896892
Add recursive handling of too many buckets
Zacqary b804e5c
Update comment
Zacqary db10b8d
Avoid re-fetching groups every iteration
Zacqary 2993450
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary 2bbe889
Fix i18n
Zacqary 84385f1
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary 04b5eee
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary d3b8bab
Merge branch 'master' into 65830-alert-preview
elasticmachine a22e6b8
Clean up interpolation and apply useCallbacks
Zacqary 1de9ca6
Merge remote-tracking branch 'upstream/master' into 65830-alert-preview
Zacqary 8dd4219
Merge branch '65830-alert-preview' of github.com:Zacqary/kibana into …
Zacqary File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should move these types to the common directory. That will have the added bonus of allowing us to remove
// eslint-disable-next-line @kbn/eslint/no-restricted-paths