Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error when encountering corrupt saved object during migration #65829

Merged
merged 4 commits into from
May 11, 2020

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented May 8, 2020

Summary

Adds logging when we encounter corrupt saved objects that could lead to the issue described in #65612. This just makes it easier to detect and debug this problem in the short-term (7.8) while we're working on the fix in #64885

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@rudolf rudolf added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects v7.8.0 labels May 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@rudolf rudolf requested a review from mshustov May 8, 2020 10:16
@rudolf rudolf force-pushed the log-invalid-saved-object branch from 48b24a9 to abeae0d Compare May 8, 2020 10:18
@rudolf rudolf marked this pull request as ready for review May 8, 2020 10:18
@rudolf rudolf requested a review from a team as a code owner May 8, 2020 10:18
@rudolf rudolf added the release_note:skip Skip the PR/issue when compiling release notes label May 8, 2020
@rudolf rudolf force-pushed the log-invalid-saved-object branch from abeae0d to 5884dcf Compare May 8, 2020 10:20
@rudolf rudolf requested a review from a team as a code owner May 8, 2020 18:49
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@rudolf rudolf merged commit b180fd3 into elastic:master May 11, 2020
@rudolf rudolf deleted the log-invalid-saved-object branch May 11, 2020 13:00
rudolf added a commit to rudolf/kibana that referenced this pull request May 11, 2020
…astic#65829)

* Log error when encountering corrupt saved object during migration

* Fix documentation

* Fix types
rudolf added a commit to rudolf/kibana that referenced this pull request May 11, 2020
…astic#65829)

* Log error when encountering corrupt saved object during migration

* Fix documentation

* Fix types
rudolf added a commit that referenced this pull request May 11, 2020
…5829) (#66013)

* Log error when encountering corrupt saved object during migration

* Fix documentation

* Fix types
rudolf added a commit that referenced this pull request May 11, 2020
…5829) (#66014)

* Log error when encountering corrupt saved object during migration

* Fix documentation

* Fix types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Saved Objects release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants