-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log error when encountering corrupt saved object during migration #65829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/kibana-platform (Team:Platform) |
48b24a9
to
abeae0d
Compare
abeae0d
to
5884dcf
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mshustov
approved these changes
May 11, 2020
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
May 11, 2020
…astic#65829) * Log error when encountering corrupt saved object during migration * Fix documentation * Fix types
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
May 11, 2020
…astic#65829) * Log error when encountering corrupt saved object during migration * Fix documentation * Fix types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Saved Objects
release_note:skip
Skip the PR/issue when compiling release notes
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
v7.8.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds logging when we encounter corrupt saved objects that could lead to the issue described in #65612. This just makes it easier to detect and debug this problem in the short-term (7.8) while we're working on the fix in #64885
Checklist
Delete any items that are not applicable to this PR.
For maintainers