Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mock the whole ES client in the integration tests #65081

Merged
merged 3 commits into from
May 4, 2020
Merged

mock the whole ES client in the integration tests #65081

merged 3 commits into from
May 4, 2020

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented May 4, 2020

Summary

closes #64310
mock ES client to prevent plugins from calling callAsInternalUser.

Checklist

For maintainers

@mshustov mshustov added chore release_note:skip Skip the PR/issue when compiling release notes v7.8.0 Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels May 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov marked this pull request as ready for review May 4, 2020 15:39
@mshustov mshustov requested a review from a team as a code owner May 4, 2020 15:39
@mshustov
Copy link
Contributor Author

mshustov commented May 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit f98f4f2 into elastic:master May 4, 2020
@mshustov mshustov mentioned this pull request May 4, 2020
Merged
mshustov added a commit to mshustov/kibana that referenced this pull request May 4, 2020
@mshustov @elasticmachine
mock the whole ES client in the integration tests (elastic#65081)
5987765 
* mock the whole ES client to prevent real requests

* mock the whole client

Co-authored-by: Elastic Machine <[email protected]>
@mshustov mshustov deleted the fix-intergraion-tests-error branch May 4, 2020 19:52
spalger pushed a commit that referenced this pull request May 4, 2020
@mshustov @elasticmachine
mock the whole ES client in the integration tests (#65081) (#65149)
4ca7a2f 
* mock the whole ES client to prevent real requests

* mock the whole client

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.8.0
Projects
None yet
Milestone
No milestone
4 participants
@mshustov @elasticmachine @kibanamachine @pgayvallet