Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.8] Dependency updates #64936

Merged
merged 25 commits into from
May 4, 2020
Merged

[6.8] Dependency updates #64936

merged 25 commits into from
May 4, 2020

Conversation

jportner
Copy link
Contributor

@jportner jportner commented Apr 30, 2020 •
edited
Loading

This PR manually backports several dependency updates. See each commit message for details.

Additional notes:

  • aeb4f50 - the mixin-deep package update was updated from 1.3.1 to 1.3.2 in Kibana 7.5+ (via Updating mixin-deep #46412).
    • This commit also caused a few changes to the packages/kbn-pm/dist/index.js file (rebuilt using the yarn kbn run build -i @kbn/pm command). These changes match those from the original PR.
  • b4d2194 - the tar package was updated from 2.2.0 to 4.4.8 in Kibana 7.2+ (via Update archiving dependencies #35896), but this entailed several additional changes to code that uses this package. Instead, I opted to update this package's patch version to 2.2.2.
  • cea2dbe - the tar-fs package was removed in Kibana 7.2+ (via Update archiving dependencies #35896), but it is still used in Kibana 6.8, so I updated it here.
  • 930963c - the set-value package was updated in the master branch at some point (verified by examining our yarn.lock file), but I was not able to easily identify which PR updated this because it is a transitive dependency several layers deep. I updated the resolution to the latest patch version.
    • This commit also caused several changes to the packages/kbn-pm/dist/index.js file (rebuilt using the yarn kbn run build -i @kbn/pm command).
  • 853736d - the extend package was updated in the master branch at some point (verified by examining our yarn.lock file), but I was not able to easily identify which PR updated this because it is a transitive dependency several layers deep. I updated the resolution to the latest patch version.

jportner added 6 commits April 30, 2020 13:30
@jportner
Update js-yaml dependency (elastic#37809, elastic#38160, elastic#46405
c42d3d1 
)
@jportner
Update fstream dependency (elastic#53932)
38807c0
@jportner
Update tar dependency
b4d2194 
Includes update to `geckodriver`, which uses `tar` as a transitive
dependency.
Now, `tar` 2.x and 4.x each resolve to the latest patch version for
those majors.
@jportner
Update tar-fs dependency
cea2dbe 
Checked our usage of this and it is very simple, also did a cursory
check of changes between `tar-fs` versions 1.13.0 and 1.16.3 -- did
not find any changes that appeared to be breaking or that would
otherwise affect our usage of this package.
@jportner
Update serialize-javascript dependency (elastic#52336)
8915800 
The PR this backports actually updated the resolution from 1.7.0 to
2.1.1. This commit updates the resolution from 1.5.0 to 2.1.1.
I checked the changelog and it doesn't appear that there are any
breaking changes between 1.5.0 and 1.7.0, so this should be safe to
update.
@jportner
Update angular dependency (elastic#37610, elastic#37611, elastic#46393
c191eae 
, elastic#51174)

This combines backports from several PRs. elastic#46393 contained three
changes to source code:
* heatmap_options.html: I made the change and did a smoke-test of
  a heatmap using sample data, did not notice any problems.
* sub_url_route_filter.js: I made this change, it is a test file
  so I will rely on CI to exercise it.
* screenshots.js: This change appears to be superseded by another
  PR, elastic#46667, so I omitted the change from this backport.
@jportner jportner requested a review from legrego April 30, 2020 17:46
@jportner jportner added the chore label Apr 30, 2020
jportner added 17 commits April 30, 2020 15:24
@jportner
Update mixin-deep dependency (elastic#38057, elastic#46412)
aeb4f50
@jportner
Update set-value dependency
930963c 
This is a transitive dependency. It has been updated in newer
versions of Kibana, but I could not find the PR that changed
the master branch.
@jportner
Update extend dependency
853736d 
This is a transitive dependency. It has been updated in newer
versions of Kibana, but I could not find the PR that changed
the master branch.
@jportner
Update acorn dependency (elastic#61708)
f69287a 
This is a transitive dependency.
@jportner
Update papaparse dependency (elastic#43950, elastic#63879)
f2c54be 
Note: the PRs this backports also included updates to the
`@types/papaparse` package, but Kibana 6.8 does not use that
package. So this commit ignores that package.
@jportner
Remove pivotal-ui dependency (elastic#30975)
6a7e65d 
In the PR this backports, the `pivotal-ui` package is no longer in
use and could be removed. I double-checked and Kibana 6.8 does not
use this package either, so we can backport that PR.
@jportner
Remove react-markdown-renderer dependency (elastic#46414)
16be1a7 
In the PR this backports, the `react-markdown-renderer` package is
no longer in use and could be removed. I double-checked and Kibana
6.8 does not use this package either, so we can backport that PR.
@jportner
Update yargs dependency (elastic#57720)
16ab35d 
This is a transitive dependency.
@jportner
Update vega-util dependency (elastic#61125)
cd3b11c 
This is a transitive dependency.
@jportner
Update https-proxy-agent dependency (elastic#44807, elastic#58296)
e8937b0
@jportner
Update extract-zip dependency (elastic#37766, elastic#61209)
909d9af 
Note: elastic#61209 also changes transitive dependency resolutions for the
`mkdirp` package; this commit omits those changes.
@jportner
Update concat-stream dependency (elastic#37730)
a11a961 
Also condensed other transitive dependency resolutions so they all
use the same patch version.
@jportner
Update elliptic dependency (elastic#54476)
1a9ef0d 
This is a transitive dependency.
@jportner
Update chownr dependency (elastic#38177)
c88b1a1 
This is a transitive dependency.
@jportner
Update handlebars dependency (elastic#64402)
fae3183 
I only updated the direct dependency. There are a couple of
transitive dependencies which still resolve to older versions, but
these are sourced from devDependencies and not a priority to be
updated.
@jportner
Update markdown-it dependency (elastic#51492)
8d22bf9
@jportner
Update jquery dependency (elastic#35177, elastic#35908)
eef653f 
Note, there is still a transitive dependency that resolves to an
older version. I did not want to upgrade this as it may break
things, and it's part of the `@elastic/eui` package which has been
updated in newer versions of Kibana.
@jportner jportner force-pushed the 6.8-dependency-updates branch from 74f47b3 to eef653f Compare April 30, 2020 19:57
@jportner
Downgrade jquery dependency
d6b90c8 
eef653f was intended to update `jquery` to 3.4.1, but it actually
updated to 3.5.0. That version includes a breaking change that
causes as-of-yet unknown issues, including CI failures.
This commit downgrades `jquery` to 3.4.1, which is known to work
with Kibana 7.2+.
@legrego
Copy link
Member

legrego commented May 1, 2020

retest

@jportner
Copy link
Contributor Author

jportner commented May 1, 2020 •
edited
Loading

I am getting errors when I run yarn grunt test:browser-ci:

HeadlessChrome 81.0.4044 (Mac OS X 10.14.6) Vis-Editor-Agg-Params plugin directive should show custom label parameter FAILED
        TypeError: Cannot read property '$$nextSibling' of null
            at Scope.$digest (webpack://%5Bname%5D/./node_modules/angular/angular.js?:19173:61)
            at init (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:244347:19)
            at Context.<anonymous> (http://localhost:5610/bundles/tests.bundle.js?shards=4&shard_num=1:244356:5)

This matches what we are seeing in the CI failure here.

I tried reverting all commits and I am still getting that error. Don't know what exactly is going on, but I don't think it's being caused by any of the commits in this PR. Will need to revisit it next week.

Edit: this appears to be the same issue: #24684

@jportner
Copy link
Contributor Author

jportner commented May 4, 2020

It appears that c191eae is responsible for two CI failures:

  1. The Infrastructure app does not load at all -- navigating to it just shows a blank page
  2. The Watcher app table selection is broken:

May-04-2020 10-36-47

Since that's just what CI is catching, and the Angular update could (probably does) have broader impact, I think it's best to revert that change for now, and revisit later if we deem it necessary.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jportner jportner marked this pull request as ready for review May 4, 2020 16:02
@jportner jportner added the release_note:skip Skip the PR/issue when compiling release notes label May 4, 2020
legrego
legrego approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jportner jportner merged commit a860ad6 into elastic:6.8 May 4, 2020
@jportner jportner deleted the 6.8-dependency-updates branch May 4, 2020 18:30
@jportner jportner mentioned this pull request Aug 11, 2020
Closed
@jportner jportner mentioned this pull request Apr 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
chore release_note:skip Skip the PR/issue when compiling release notes v6.8.9
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jportner @legrego @kibanamachine