Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Changes transforms wizard UI text #64150

Merged
merged 7 commits into from
Apr 24, 2020
Merged

[ML] Changes transforms wizard UI text #64150

merged 7 commits into from
Apr 24, 2020

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 22, 2020 •
edited
Loading

Summary

This PR achieves the following:

  • deletes the placeholder text of the transform ID field,
  • changes the placeholder text of the transform description field,
  • deletes the help text of the transform description field,
  • deletes the placeholder text of the destination index,
  • deletes xpack.transform.stepDetailsForm.transformDescriptionHelpText object from the translate files.

Checklist

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@szabosteve szabosteve requested a review from lcawl April 22, 2020 09:26
@szabosteve szabosteve marked this pull request as ready for review April 22, 2020 09:26
@szabosteve szabosteve requested a review from a team as a code owner April 22, 2020 09:26
@szabosteve szabosteve requested a review from walterra April 22, 2020 09:27
@szabosteve szabosteve added the release_note:skip Skip the PR/issue when compiling release notes label Apr 22, 2020
@peteharverson peteharverson changed the title Changes transforms wizard UI text [ML] Changes transforms wizard UI text Apr 22, 2020
@szabosteve @walterra
Update x-pack/plugins/transform/public/app/sections/create_transform/…
f607a43 
…components/step_details/step_details_form.tsx

Co-Authored-By: Walter Rafelsberger <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

walterra
walterra approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lcawl
lcawl approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM too

@szabosteve szabosteve merged commit 222fba5 into elastic:master Apr 24, 2020
@szabosteve szabosteve deleted the ml-ui-rev branch April 24, 2020 07:01
@szabosteve szabosteve mentioned this pull request Apr 24, 2020
Merged
1 task
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 24, 2020
@gmmorris
Merge branch 'master' into alerting/no-explicit-any
7b89039 
* master: (70 commits)
  KQL removes leading zero and breaks query (elastic#62748)
  [FieldFormats] Cleanup: rename IFieldFormatType -> FieldFormatInstanceType (elastic#64193)
  [ML] Changes transforms wizard UI text (elastic#64150)
  [Alerting] change server log action type .log to .server-log in README (elastic#64124)
  [Metrics UI] Design Refresh: Inventory View, Episode 1 (elastic#64026)
  chore(NA): reduce siem bundle size using babel-plugin-transfor… (elastic#63269)
  chore(NA): use core-js instead of babel-polyfill on canvas sha… (elastic#63486)
  skip flaky suite (elastic#61173)
  skip flaky suite (elastic#62497)
  Renamed ilm policy for event log so it is not prefixed with dot (elastic#64262)
  [eslint] no_restricted_paths config cleanup (elastic#63741)
  Add Oil Rig Icon from @elastic/maki (elastic#64364)
  [Maps] Migrate Maps embeddables to NP (elastic#63976)
  [Ingest] Data streams list page (elastic#64134)
  chore(NA): add file-loader into jest moduleNameMapper (elastic#64330)
  [DOCS] Added images to automating report generation (elastic#64333)
  [SIEM][CASE] Api Integration Tests: Configuration (elastic#63948)
  Expose ability to check if API Keys are enabled (elastic#63454)
  [DOCS] Fixes formatting in alerting doc (elastic#64338)
  [data.search.aggs]: Create agg types function for terms agg. (elastic#63541)
  ...
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 28, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64150 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 64150 or prevent reminders by adding the backport:skip label.

@szabosteve szabosteve added the backport:skip This commit does not require backporting label Apr 29, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@lcawl lcawl lcawl approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szabosteve @elasticmachine @kibanamachine @walterra @lcawl