Fix endpoint host list test

x-pack/test/functional_endpoint/apps/endpoint/host_list.ts

@@ -12,134 +12,127 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
   const esArchiver = getService('esArchiver');
   const testSubjects = getService('testSubjects');
 
-  // FLAKY: https://github.com/elastic/kibana/issues/63621
-  describe.skip('host list', function() {
+  describe('host list', function() {
     this.tags('ciGroup7');
     const sleep = (ms = 100) => new Promise(resolve => setTimeout(resolve, ms));
     before(async () => {
-      await esArchiver.load('endpoint/metadata/api_feature');
       await pageObjects.common.navigateToUrlWithBrowserHistory('endpoint', '/hosts');
       await pageObjects.header.waitUntilLoadingHasFinished();
     });
 
-    it('finds title', async () => {
-      const title = await testSubjects.getVisibleText('hostListTitle');
-      expect(title).to.equal('Hosts');
-    });
-
-    it('displays table data', async () => {
-      const expectedData = [
-        [
-          'Hostname',
-          'Policy',
-          'Policy Status',
-          'Alerts',
-          'Operating System',
-          'IP Address',
-          'Sensor Version',
-          'Last Active',
-        ],
-        [
-          'cadmann-4.example.com',
-          'Policy Name',
-          'Policy Status',
-          '0',
-          'windows 10.0',
-          '10.192.213.130, 10.70.28.129',
-          'version',
-          'xxxx',
-        ],
-        [
-          'thurlow-9.example.com',
-          'Policy Name',
-          'Policy Status',
-          '0',
-          'windows 10.0',
-          '10.46.229.234',
-          'version',
-          'xxxx',
-        ],
-        [
-          'rezzani-7.example.com',
-          'Policy Name',
-          'Policy Status',
-          '0',
-          'windows 10.0',
-          '10.101.149.26, 2606:a000:ffc0:39:11ef:37b9:3371:578c',
-          'version',
-          'xxxx',
-        ],
-      ];
-      const tableData = await pageObjects.endpoint.getEndpointAppTableData('hostListTable');
-      expect(tableData).to.eql(expectedData);
-    });
-
-    it('no details flyout when host page displayed', async () => {
-      await testSubjects.missingOrFail('hostDetailsFlyout');
-    });
-
-    it('display details flyout when the hostname is clicked on', async () => {
-      await (await testSubjects.find('hostnameCellLink')).click();
-      await testSubjects.existOrFail('hostDetailsUpperList');
-      await testSubjects.existOrFail('hostDetailsLowerList');
-    });
-
-    it('update details flyout when new hostname is clicked on', async () => {
-      // display flyout for the first host in the list
-      await (await testSubjects.findAll('hostnameCellLink'))[0].click();
-      await testSubjects.existOrFail('hostDetailsFlyoutTitle');
-      const hostDetailTitle0 = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
-      // select the 2nd host in the host list
-      await (await testSubjects.findAll('hostnameCellLink'))[1].click();
-      await pageObjects.endpoint.waitForVisibleTextToChange(
-        'hostDetailsFlyoutTitle',
-        hostDetailTitle0
-      );
-      const hostDetailTitle1 = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
-      expect(hostDetailTitle1).to.not.eql(hostDetailTitle0);
-    });
-
-    it('details flyout remains the same when current hostname is clicked on', async () => {
-      // display flyout for the first host in the list
-      await (await testSubjects.findAll('hostnameCellLink'))[1].click();
-      await testSubjects.existOrFail('hostDetailsFlyoutTitle');
-      const hostDetailTitleInitial = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
-      // select the same host in the host list
-      await (await testSubjects.findAll('hostnameCellLink'))[1].click();
-      await sleep(500); // give page time to refresh and verify it did not change
-      const hostDetailTitleNew = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
-      expect(hostDetailTitleNew).to.eql(hostDetailTitleInitial);
-    });
-
-    describe('no data', () => {
+    describe('with data', () => {
       before(async () => {
-        // clear out the data and reload the page
-        await esArchiver.unload('endpoint/metadata/api_feature');
+        await esArchiver.load('endpoint/metadata/api_feature');
         await pageObjects.common.navigateToUrlWithBrowserHistory('endpoint', '/hosts');
         await pageObjects.header.waitUntilLoadingHasFinished();
+        await pageObjects.endpoint.waitForTableToHaveData('hostListTable');
       });
       after(async () => {
-        // reload the data so the other tests continue to pass
-        await esArchiver.load('endpoint/metadata/api_feature');
+        await esArchiver.unload('endpoint/metadata/api_feature');
       });
-      it('displays no items found when empty', async () => {
-        // get the host list table data and verify message
-        const [, [noItemsFoundMessage]] = await pageObjects.endpoint.getEndpointAppTableData(
-          'hostListTable'
+      it('finds title', async () => {
+        const title = await testSubjects.getVisibleText('hostListTitle');
+        expect(title).to.equal('Hosts');
+      });
+
+      it('displays table data', async () => {
+        const expectedData = [
+          [
+            'Hostname',
+            'Policy',
+            'Policy Status',
+            'Alerts',
+            'Operating System',
+            'IP Address',
+            'Sensor Version',
+            'Last Active',
+          ],
+          [
+            'cadmann-4.example.com',
+            'Policy Name',
+            'Policy Status',
+            '0',
+            'windows 10.0',
+            '10.192.213.130, 10.70.28.129',
+            'version',
+            'xxxx',
+          ],
+          [
+            'thurlow-9.example.com',
+            'Policy Name',
+            'Policy Status',
+            '0',
+            'windows 10.0',
+            '10.46.229.234',
+            'version',
+            'xxxx',
+          ],
+          [
+            'rezzani-7.example.com',
+            'Policy Name',
+            'Policy Status',
+            '0',
+            'windows 10.0',
+            '10.101.149.26, 2606:a000:ffc0:39:11ef:37b9:3371:578c',
+            'version',
+            'xxxx',
+          ],
+        ];
+        const tableData = await pageObjects.endpoint.getEndpointAppTableData('hostListTable');
+        expect(tableData).to.eql(expectedData);
+      });
+
+      it('no details flyout when host page displayed', async () => {
+        await testSubjects.missingOrFail('hostDetailsFlyout');
+      });
+
+      it('display details flyout when the hostname is clicked on', async () => {
+        await (await testSubjects.find('hostnameCellLink')).click();
+        await testSubjects.existOrFail('hostDetailsUpperList');
+        await testSubjects.existOrFail('hostDetailsLowerList');
+      });
+
+      it('update details flyout when new hostname is clicked on', async () => {
+        // display flyout for the first host in the list
+        await (await testSubjects.findAll('hostnameCellLink'))[0].click();
+        await testSubjects.existOrFail('hostDetailsFlyoutTitle');
+        const hostDetailTitle0 = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
+        // select the 2nd host in the host list
+        await (await testSubjects.findAll('hostnameCellLink'))[1].click();
+        await pageObjects.endpoint.waitForVisibleTextToChange(
+          'hostDetailsFlyoutTitle',
+          hostDetailTitle0
         );
-        expect(noItemsFoundMessage).to.equal('No items found');
+        const hostDetailTitle1 = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
+        expect(hostDetailTitle1).to.not.eql(hostDetailTitle0);
+      });
+
+      it('details flyout remains the same when current hostname is clicked on', async () => {
+        // display flyout for the first host in the list
+        await (await testSubjects.findAll('hostnameCellLink'))[1].click();
+        await testSubjects.existOrFail('hostDetailsFlyoutTitle');
+        const hostDetailTitleInitial = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
+        // select the same host in the host list
+        await (await testSubjects.findAll('hostnameCellLink'))[1].click();
+        await sleep(500); // give page time to refresh and verify it did not change
+        const hostDetailTitleNew = await testSubjects.getVisibleText('hostDetailsFlyoutTitle');
+        expect(hostDetailTitleNew).to.eql(hostDetailTitleInitial);
       });
     });
 
     describe('has a url with a host id', () => {
       before(async () => {
+        await esArchiver.load('endpoint/metadata/api_feature');
         await pageObjects.common.navigateToUrlWithBrowserHistory(
           'endpoint',
           '/hosts',
           'selected_host=fc0ff548-feba-41b6-8367-65e8790d0eaf'
         );
         await pageObjects.header.waitUntilLoadingHasFinished();
       });
+      after(async () => {
+        await esArchiver.unload('endpoint/metadata/api_feature');
+      });
 
       it('shows a flyout', async () => {
         await testSubjects.existOrFail('hostDetailsFlyout');
@@ -175,8 +168,21 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
         ]);
       });
     });
-    after(async () => {
-      await esArchiver.unload('endpoint/metadata/api_feature');
+
+    describe('no data', () => {
+      before(async () => {
+        // clear out the data and reload the page
+        await esArchiver.unload('endpoint/metadata/api_feature');
+        await pageObjects.common.navigateToUrlWithBrowserHistory('endpoint', '/hosts');
+        await pageObjects.header.waitUntilLoadingHasFinished();
+      });
+      it('displays no items found when empty', async () => {
+        // get the host list table data and verify message
+        const [, [noItemsFoundMessage]] = await pageObjects.endpoint.getEndpointAppTableData(
+          'hostListTable'
+        );
+        expect(noItemsFoundMessage).to.equal('No items found');
+      });
     });
   });
 };