[Console] Relax error requirement of ECONNREFUSED #63835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a test for the different errors that could occur at a lower network level.
jloleysens
added
Feature:Console
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
alisonelizabeth
approved these changes
Apr 17, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 17, 2020
Also added a test for the different errors that could occur at a lower network level.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Apr 17, 2020
Also added a test for the different errors that could occur at a lower network level.
jloleysens
added a commit
that referenced
this pull request
Apr 17, 2020
jloleysens
added a commit
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Continuation of the original fix #50185. The check for
ECONNREFUSEDwas too strict and meant other errors likeEHOSTUNREACHdid not trigger the proxy fallback. This contribution relaxes that requirement so that we fallback for any network error. This should not include 4xx or 5xx responses from the server.Release note
We fixed an issue in Console that would only fallback to another Elasticsearch Node when it received an
ECONNREFUSEDerror. It will now fallback in the event of any issue connect to a node mirroring the fallback behaviour of other Kibana functionality.Checklist