-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split action types into own page #63516
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
@gchaps this is what I have as the landing page now for the action and connector types. All the content that was there previously is now moved into their own sub-pages. One sentence from the previous page is "This section describes how to configure connectors and actions for each type." which I'm not sure what to do with to instruct the reader to select an action type to see how to configure them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mikecote The sentence "This section describes how to configure connectors and actions for each type." isn't needed here, so OK to remove. Instead, I suggest starting with a description about what an action is. Maybe something like this (but without the word invocation).
Actions are invocations of Kibana services or integrations with third-party systems, that run as background tasks on the Kibana server when alert conditions are met.
Also, would it be helpful to the user to add a 1-line description about what each action is? Something similar to how its done on this page: https://www.elastic.co/guide/en/kibana/master/devtools-kibana.html
For the action types, I recall a suggestion to add a snapshot to each page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-Authored-By: gchaps <[email protected]>
Updated landing page based on @gchaps feedback: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Split action types into own page * Update docs/user/alerting/action-types.asciidoc Co-Authored-By: gchaps <[email protected]> * Apply changes based on feedback Co-authored-by: gchaps <[email protected]>
* Split action types into own page * Update docs/user/alerting/action-types.asciidoc Co-Authored-By: gchaps <[email protected]> * Apply changes based on feedback Co-authored-by: gchaps <[email protected]>
* Split action types into own page * Update docs/user/alerting/action-types.asciidoc Co-Authored-By: gchaps <[email protected]> * Apply changes based on feedback Co-authored-by: gchaps <[email protected]> Co-authored-by: gchaps <[email protected]>
* Split action types into own page * Update docs/user/alerting/action-types.asciidoc Co-Authored-By: gchaps <[email protected]> * Apply changes based on feedback Co-authored-by: gchaps <[email protected]> Co-authored-by: gchaps <[email protected]>
* master: (56 commits) [i18n] Update CODEOWNERS (elastic#63354) add platform team definition of done (elastic#59993) [SIEM] move away from Joi for importing/exporting timeline (elastic#62125) Fix discover preserve url (elastic#63580) [alerting] Adds an alertServices mock and uses it in siem, monitoring and uptime (elastic#63489) Closes elastic#63109 for Service Map by resetting edges styles for the selected node (elastic#63655) MIgrated index_header to react (elastic#63490) Index pattern management UI -> TypeScript and New Platform Ready (indexed_fields_table) (elastic#63364) [SIEM] [Cases] Insert timeline and reporters/tags in table bug fixes (elastic#63642) [Reporting] Make usable default element positions (elastic#63191) [Reporting] Switch Serverside Config Wrapper to NP (elastic#62500) [Reporting] Add "warning" status as an alternate type of completed job (elastic#63498) Split action types into own page (elastic#63516) [Lens] Only show copy on save for previously saved docs (elastic#63535) Update README.md (elastic#63622) Bugfix clear saved query crashes kibana on Discover in some cases (elastic#63554) Add uptime CODEOWNER entries. (elastic#63616) [ML] Extract apiDoc params from the schema definitions (elastic#62933) Fix alerting documentation encryption key requirement (elastic#63512) Fix CODEOWNERS and sass lint paths (elastic#63552) ...
Fixes #62445
Landing page:
