[APM] Agent span_frames_min_duration configuration input cannot handle 0 or -1

[cauemarcondes]

closes #62569

[smith]

It works in general, but if I set the value to -2 or less I get an error "Please specify an integer and a unit" on the field. This works in that we're validating that we don't want < -1, but is confusing. Could we put min="-1" on the number input element?

Let me know if that's not possible and I'll approve, but while this fixes the main problem, the < -1 behavior is still weird.

[cauemarcondes]

It works in general, but if I set the value to -2 or less I get an error "Please specify an integer and a unit" on the field. This works in that we're validating that we don't want < -1, but is confusing. Could we put min="-1" on the number input element?

Let me know if that's not possible and I'll approve, but while this fixes the main problem, the < -1 behavior is still weird.

I can change the error message to something like Please specify an integer greater than -1 and a unit, WDYT?

[smith]

@cauemarcondes

I can change the error message to something like Please specify an integer greater than -1 and a unit, WDYT?

Yes that's probably fine for now. Using the min attribute on the field is something we could come back to later.

[cauemarcondes]

@cauemarcondes

I can change the error message to something like Please specify an integer greater than -1 and a unit, WDYT?

Yes that's probably fine for now. Using the min attribute on the field is something we could come back to later.

Ok, it was an easy fix to add the min property. 4321992, I added the default value as 1, because before the duration was validating if the value was > 0.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 4321992

History

• 💚 Build #39229 succeeded fb59574

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream