[Uptime] Default uptime alert type and disable changing type #62028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
force-pushed
the
uptime_alerting-fix-no-default-type
branch
from
82b32fe to
85b99e5
Compare
andrewvc
approved these changes
Apr 2, 2020
NP - I will resolve the type conflict soon and get this mergeable. |
justinkambic
force-pushed
the
uptime_alerting-fix-no-default-type
branch
from
292b1fc to
cd47049
Compare
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Apr 6, 2020
…#62028) * Default uptime alert type and disable changing type. * Update functional test to handle new UI flow. * Fix type error. Co-authored-by: Elastic Machine <[email protected]>
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Apr 6, 2020
…#62028) * Default uptime alert type and disable changing type. * Update functional test to handle new UI flow. * Fix type error. Co-authored-by: Elastic Machine <[email protected]>
justinkambic
added a commit
that referenced
this pull request
Apr 6, 2020
…#62627) * Default uptime alert type and disable changing type. * Update functional test to handle new UI flow. * Fix type error. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
justinkambic
added a commit
that referenced
this pull request
Apr 8, 2020
…62028) (#62628) * [Uptime] Default uptime alert type and disable changing type (#62028) * Default uptime alert type and disable changing type. * Update functional test to handle new UI flow. * Fix type error. Co-authored-by: Elastic Machine <[email protected]> * Fix broken type. Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61836.
We had discussed making it so that the Uptime alert is the default UI shown in our alert flyout, and disabling the feature that allows the user to change the type. We even wrote code for this but seem to have forgotten to supply the props necessary for the feature to engage.
This PR is designed to add (remove?) that functionality.
Testing this PR
Checklist
Delete any items that are not applicable to this PR.
For maintainers