[Fleet] add Agent config details yaml view #60943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
v8.0.0
release_note:skip
|
Pinging @elastic/ingest-management (Feature:Fleet) |
jen-huang
approved these changes
Mar 23, 2020
| /> | ||
| </h3> | ||
| </EuiTitle> | ||
| <EuiSpacer size={'m'} /> |
There was a problem hiding this comment.
👍it's annoying that prettier do not catch things like that
| defaultMessage="To enroll an agent with this configuration, copy and run the following command on your host." | ||
| /> | ||
| </EuiText> | ||
| <EuiSpacer size={'m'} /> |
| <EuiSpacer size={'m'} /> | ||
| <EuiText size="s"> | ||
| <FormattedMessage | ||
| id="xpack.ingestManager.yamlConfig.instructionDescription " |
| <EuiTitle size="s"> | ||
| <h3> | ||
| <FormattedMessage | ||
| id="xpack.ingestManager.yamlConfig.instructionTittle " |
There was a problem hiding this comment.
trailing space and typo - instructionTitle
|
@elasticmachine merge upstream |
nchaulet
added a commit
to nchaulet/kibana
that referenced
this pull request
Mar 23, 2020
nchaulet
added a commit
that referenced
this pull request
Mar 23, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
22 tasks
jen-huang
added
the
Team:Fleet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #57958
While working on fleet it help a lot to be able to visualize the yaml config. So I implemented the tab.
I did not implemented the full enrollment UI as in the design, as it's currently still under discussion.
UI changes
Questions
There is no api key in the full config as the api key are per agent do we still want to have one for the standalone agent scenario (not using fleet) cc @ph @michalpristas