Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

es6 module - hoist private module providers #6078

Closed

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 3, 2016

Find all usage of Private(require('...')); and convert it into two things:

at the top/under the other imports of a file:

import ...Provider from '...';

replace the original statements with:

Private(...Provider);

@spalger spalger force-pushed the implement/es6Modules/privateProviders branch from e499b5a to 535bfae Compare February 3, 2016 02:03
@spalger spalger force-pushed the implement/es6Modules/privateProviders branch from 535bfae to 235f741 Compare February 3, 2016 17:47
@epixa
Copy link
Contributor

epixa commented Feb 3, 2016

Test failure

@spalger spalger force-pushed the implement/es6Modules/privateProviders branch from 235f741 to a668ec9 Compare February 3, 2016 22:59
@spalger
Copy link
Contributor Author

spalger commented Feb 4, 2016

resubmitting from elastic:implement/es6Modules/privateProviders

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants