[Lens] Improve suggestions when dragging field for the second time #60687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wylieconlon
added
release_note:enhancement
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
timroes
reviewed
Mar 20, 2020
| const [, metrics] = separateBucketColumns(layer); | ||
|
|
||
| // Add new metric if we already have multiple | ||
| if (metrics.length > 1) { |
There was a problem hiding this comment.
We currently not using this path if metrics.length === 0, and then later executing code like delete newColumns[metrics[0]] where metrics[0] is undefined. This happens to work, but I think it would be a bit nicer, if we would also use this path if metrics.length === 0, since we don't then access metrics[0] and it could look a bit more clear. (At that point maybe we want to switch that if with the code below and make it a metrics.length === 1-if instead.
timroes
approved these changes
Mar 20, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
Mar 23, 2020
…lastic#60687) * [Lens] Improve suggestions when dragging into an existing visualization * Include 0 metrics case Co-authored-by: Elastic Machine <[email protected]>
wylieconlon
pushed a commit
that referenced
this pull request
Mar 24, 2020
…60687) (#60996) * [Lens] Improve suggestions when dragging into an existing visualization * Include 0 metrics case Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This was referenced Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note
Improves suggestion logic when dragging fields into the chart. Specifically:
Checklist