Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] add functional tests for index threshold alertType #60597

Merged
merged 1 commit into from
Mar 19, 2020
Merged

[Alerting] add functional tests for index threshold alertType #60597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions x-pack/plugins/alerting_builtins/server/alert_types/index_threshold/alert_type.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ export function getAlertType(service: Service): AlertType {
timeWindowUnit: params.timeWindowUnit,
interval: undefined,
};
// console.log(`index_threshold: query: ${JSON.stringify(queryParams, null, 4)}`);
const result = await service.indexThreshold.timeSeriesQuery({
logger,
callCluster,
Expand All @@ -121,6 +122,7 @@ export function getAlertType(service: Service): AlertType {
logger.debug(`alert ${ID}:${alertId} "${name}" query result: ${JSON.stringify(result)}`);

const groupResults = result.results || [];
// console.log(`index_threshold: response: ${JSON.stringify(groupResults, null, 4)}`);
for (const groupResult of groupResults) {
const instanceId = groupResult.group;
const value = groupResult.metrics[0][1];
Expand Down
23 changes: 11 additions & 12 deletions x-pack/test/alerting_api_integration/common/lib/es_test_index_tool.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,18 @@
* you may not use this file except in compliance with the Elastic License.
*/

export const ES_TEST_INDEX_NAME = '.kibaka-alerting-test-data';
export const ES_TEST_INDEX_NAME = '.kibana-alerting-test-data';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

been meaning to change this for a while :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ go kibaka!


export class ESTestIndexTool {
private readonly es: any;
private readonly retry: any;

constructor(es: any, retry: any) {
this.es = es;
this.retry = retry;
}
constructor(
private readonly es: any,
private readonly retry: any,
private readonly index: string = ES_TEST_INDEX_NAME
) {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL, you can define right in the constructor!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not often we get to do this, since we often pass an object with props as the constructor arg, and I don't think you can use this trick for that. But I try to use it wherever I can!


async setup() {
return await this.es.indices.create({
index: ES_TEST_INDEX_NAME,
index: this.index,
body: {
mappings: {
properties: {
Expand Down Expand Up @@ -56,12 +54,13 @@ export class ESTestIndexTool {
}

async destroy() {
return await this.es.indices.delete({ index: ES_TEST_INDEX_NAME, ignore: [404] });
return await this.es.indices.delete({ index: this.index, ignore: [404] });
}

async search(source: string, reference: string) {
return await this.es.search({
index: ES_TEST_INDEX_NAME,
index: this.index,
size: 1000,
body: {
query: {
bool: {
Expand All @@ -86,7 +85,7 @@ export class ESTestIndexTool {
async waitForDocs(source: string, reference: string, numDocs: number = 1) {
return await this.retry.try(async () => {
const searchResult = await this.search(source, reference);
if (searchResult.hits.total.value !== numDocs) {
if (searchResult.hits.total.value < numDocs) {
throw new Error(`Expected ${numDocs} but received ${searchResult.hits.total.value}.`);
}
return searchResult.hits.hits;
Expand Down
Loading