Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[savedObjects] change the number mappings to be 'long' #5934

Merged
merged 1 commit into from
Jan 20, 2016

Conversation

epixa
Copy link
Contributor

@epixa epixa commented Jan 19, 2016

Since JavaScript numbers can't actually be integers we don't really
care about the difference between int and long, but since the long
is the default type it makes things more frictionless

Original
issue: #3882
commit: 1b9a646
author: @spalger

This change went into 4.1 but was somehow left out of 4.2 onward.

Since JavaScript numbers can't actually be integers we don't really
care about the difference between int and long, but since the long
is the default type it makes things more frictionless

Original
commit: 1b9a646
author: @spalger
@epixa epixa added the v4.3.2 label Jan 19, 2016
@epixa
Copy link
Contributor Author

epixa commented Jan 19, 2016

Issued as a separate PR to verify that tests pass.

@epixa epixa self-assigned this Jan 20, 2016
spalger added a commit that referenced this pull request Jan 20, 2016
[savedObjects] change the number mappings to be 'long'
@spalger spalger merged commit a083129 into elastic:4.3 Jan 20, 2016
@epixa epixa deleted the 3882-4.3-mapper-longints branch January 21, 2016 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants