Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] [Case] All cases page design updates #59248

Merged
merged 20 commits into from
Mar 5, 2020
Merged

[SIEM] [Case] All cases page design updates #59248

merged 20 commits into from
Mar 5, 2020

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Mar 3, 2020 •
edited
Loading

Summary

This PR implements design updates to the All Cases page. Including:

  • add selections to table
  • updated columns (WIP, need closed_at time field)
  • add bulk actions UI (WIP)
  • add actions column (open/close works, the other actions are WIP)
  • add open/closed case stats to header
  • add open/closed filters
  • add reporter filter (WIP)
  • add selection count to tags filter
  • WIP items are blocked by [SIEM] [Case] API To Dos #58525

Before:
Screen Shot 2020-03-03 at 4 26 38 PM

After:
Screen Shot 2020-03-03 at 4 23 22 PM

Open/closed filters:
open-closed

Tags filter:
tags2

Reporter filter (WIP):
reporter

Bulk actions (WIP):
bulk

Column actions (WIP):
actions

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 3, 2020
@stephmilovic stephmilovic requested review from XavierM and cnasikas March 3, 2020 23:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

stephmilovic
stephmilovic commented Mar 4, 2020
View reviewed changes
x-pack/legacy/plugins/siem/public/pages/case/components/bulk_actions/index.tsx
closePopover: () => void;
// dispatch: Dispatch<Action>;
// dispatchToaster: Dispatch<ActionToaster>;
// reFetchCases: (refreshPrePackagedCase?: boolean) => void;
Copy link
Contributor Author

@stephmilovic stephmilovic Mar 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to leave these comments in, I want to remember what was here. following up in a future PR soon

XavierM
XavierM reviewed Mar 4, 2020
View reviewed changes
x-pack/legacy/plugins/siem/public/pages/case/components/all_cases/index.tsx
}),
[selectedCases]
);
const isCasesLoading = useMemo(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing the isLoading will simplify this logic, but we still need an initLoading state to show the initial loading design and then we can have the night rider's kibana loading so people can still play with the table

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bug
got this solved but made a new bug, you can click close case again while the case is updating. ill need to add something to disable that row, because its fine if you click close case on the row below it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ill fix in a follow up so you can get your PR merged tho @XavierM

stephmilovic
stephmilovic commented Mar 5, 2020
View reviewed changes
x-pack/legacy/plugins/siem/public/containers/case/use_get_cases.tsx
didCancel = true;
};
},
[filterQuery, state.filterOptions]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XavierM this is weird, if I dont include these dependencies, when i call fetchCases() from this function it calls it with initialState filterOptions, not updated. i wouldnt expect this since fetchCases has filterOptions as a dependency?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think that I have a fix in my PR for it, so let's move one

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look at this commit in my pr coming ff92b62

XavierM
XavierM approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of the comments, we can resolve the UX loading just after my PR get merged. I/We will make sure that the API get smarter for the UI to stay in the concept of KISS

Good work for moving forward!!! Thank you @stephmilovic

@stephmilovic
Copy link
Contributor Author

@elasticmachine merge upstream

@XavierM
Copy link
Contributor

XavierM commented Mar 5, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic merged commit 91a5b17 into elastic:master Mar 5, 2020
@stephmilovic stephmilovic deleted the all-cases-design-updates branch March 5, 2020 18:29
@stephmilovic stephmilovic mentioned this pull request Mar 5, 2020
Merged
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Mar 5, 2020
@stephmilovic
[SIEM] [Case] All cases page design updates (elastic#59248)
b85de41
XavierM pushed a commit that referenced this pull request Mar 6, 2020
@stephmilovic @elasticmachine
[SIEM] [Case] All cases page design updates (#59248) (#59456)
69b5f80 
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@cnasikas cnasikas Awaiting requested review from cnasikas

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stephmilovic @elasticmachine @XavierM @kibanamachine