Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs UI] Unskip and stabilitize log column configuration tests #58392

Merged
merged 2 commits into from
Feb 25, 2020
Merged

[Logs UI] Unskip and stabilitize log column configuration tests #58392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
63ccb7f
Manipulate column configuration form more robustly
weltenwort Feb 24, 2020
8deb4c7
Remove flakyness comment
weltenwort Feb 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions x-pack/test/functional/apps/infra/logs_source_configuration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
const pageObjects = getPageObjects(['common', 'infraLogs']);
const retry = getService('retry');

// FLAKY: https://github.com/elastic/kibana/issues/58059
describe.skip('Logs Source Configuration', function() {
describe('Logs Source Configuration', function() {
this.tags('smoke');

before(async () => {
Expand Down
30 changes: 21 additions & 9 deletions x-pack/test/functional/services/infra_source_configuration_form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,25 +36,37 @@ export function InfraSourceConfigurationFormProvider({ getService }: FtrProvider
return await testSubjects.find('~addLogColumnPopover');
},
async addTimestampLogColumn() {
await (await this.getAddLogColumnButton()).click();
// try to open the popover
const popover = await retry.try(async () => {
await (await this.getAddLogColumnButton()).click();
return this.getAddLogColumnPopover();
});

// try to select the timestamp field
await retry.try(async () => {
await (
await testSubjects.findDescendant(
'~addTimestampLogColumn',
await this.getAddLogColumnPopover()
)
).click();
await (await testSubjects.findDescendant('~addTimestampLogColumn', popover)).click();
});

// wait for timestamp panel to show up
await testSubjects.findDescendant('~systemLogColumnPanel:Timestamp', await this.getForm());
},
async addFieldLogColumn(fieldName: string) {
await (await this.getAddLogColumnButton()).click();
// try to open the popover
const popover = await retry.try(async () => {
await (await this.getAddLogColumnButton()).click();
return this.getAddLogColumnPopover();
});

// try to select the given field
await retry.try(async () => {
const popover = await this.getAddLogColumnPopover();
await (await testSubjects.findDescendant('~fieldSearchInput', popover)).type(fieldName);
await (
await testSubjects.findDescendant(`~addFieldLogColumn:${fieldName}`, popover)
).click();
});

// wait for field panel to show up
await testSubjects.findDescendant(`~fieldLogColumnPanel:${fieldName}`, await this.getForm());
},
async getLogColumnPanels(): Promise<WebElementWrapper[]> {
return await testSubjects.findAllDescendant('~logColumnPanel', await this.getForm());
Expand Down