Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Trigger context (#57870) #58224

Merged
merged 1 commit into from
Feb 21, 2020
Merged

[7.x] Trigger context (#57870) #58224

merged 1 commit into from
Feb 21, 2020

Conversation

streamich
Copy link
Contributor

Backports the following commits to 7.x:

* feat: 🎸 annotate with comments Trigger and add createContext(

* feat: 🎸 add TriggerContext<T> type

* feat: 🎸 improve trigger setup in embeddable plugin

* feat: 🎸 export trigger vars and types from embeddable

* feat: 🎸 add internal representation of Trigger

* feat: 🎸 use new trigger interface to execute in vis embeddable

* feat: 🎸 add TriggerContextMapping interface

* feat: 🎸 improve trigger types

* refactor: 💡 remove trigger ID getter

* chore: 🤖 remove commented out line

* chore: 🤖 re-export more trigger stuff

* refactor: 💡 simplify Trigger interface

* suggestions

* Remove unused type

Co-authored-by: Stacey Gammon <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich merged commit c771007 into elastic:7.x Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants