Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove injected reference from home app #57836

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Remove injected reference from home app #57836

merged 3 commits into from
Feb 19, 2020

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Feb 18, 2020 •
edited
Loading

This PR get's rid of the cloudId injected variable in the home plugin. Instead, a new extension point home.tutorials.setVariable() is introduced the cloud plugin uses to integrate with home.

To test this, you need to configure the cloud env in your kibana.yml:

xpack.cloud.id: dhjfgdjshkg
xpack.cloud.apm.url: abctest
xpack.cloud.apm.secret_token: abcdefgh

This also fixes a bug currently present in 7.6.0 which prevents the cloud id from not showing up in instructions (because during migration of the cloud plugin the injected var cloudId which is used by home was removed).

@flash1293 flash1293 added Feature:Home Kibana home application Feature:NP Migration labels Feb 18, 2020
@flash1293 flash1293 marked this pull request as ready for review February 19, 2020 08:57
@flash1293 flash1293 requested a review from a team February 19, 2020 08:57
@flash1293 flash1293 added release_note:fix v7.6.1 v7.7.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Feb 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 requested a review from Bamieh February 19, 2020 08:57
@flash1293 flash1293 mentioned this pull request Feb 19, 2020
Closed
Bamieh
Bamieh approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit 28034d0 into elastic:master Feb 19, 2020
@flash1293 flash1293 deleted the de-cloud-home branch February 19, 2020 11:51
@flash1293 flash1293 mentioned this pull request Feb 19, 2020
Merged
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 19, 2020
@flash1293
Remove injected reference from home app (elastic#57836)
e5d62bd
flash1293 added a commit to flash1293/kibana that referenced this pull request Feb 19, 2020
@flash1293
Remove injected reference from home app (elastic#57836)
badceb4
@flash1293 flash1293 mentioned this pull request Feb 19, 2020
Merged
flash1293 added a commit that referenced this pull request Feb 20, 2020
@flash1293
[7.6] Remove injected reference from home app (#57836) (#57996)
d523039
flash1293 added a commit that referenced this pull request Feb 20, 2020
@flash1293
Remove injected reference from home app (#57836) (#57989)
3508f12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majagrubic majagrubic majagrubic approved these changes

@Bamieh Bamieh Bamieh approved these changes

Assignees
No one assigned
Labels
Feature:Home Kibana home application Feature:NP Migration release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.1 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@flash1293 @elasticmachine @kibanamachine @majagrubic @Bamieh