Fixing console a11y failures #57520
Merged
Fixing console a11y failures #57520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myasonik
added
Feature:Console
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
alisonelizabeth
requested review from
alisonelizabeth
and removed request for
cjcenizal
There was a problem hiding this comment.
@myasonik thanks for fixing this! I had a question about a dependency that was added, but otherwise changes LGTM.
alisonelizabeth
approved these changes
Feb 13, 2020
myasonik
force-pushed
the
fix/console-editor-labels
branch
from
ac96099 to
32e2bba
Compare
|
I took a look at this as well.Looks pretty good. I noticed that the test failures are for unrelated tests. Perhaps merging upstream will fix that. |
|
There's also a i18n check that is looking for some labels. |
added 2 commits
February 14, 2020 10:26
|
retest |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
myasonik
pushed a commit
that referenced
this pull request
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Though the workaround present before satisfied axe, it both didn't fix the original a11y problem and in some ways made the issue worse by setting the textarea label to be the entirety of the inner contents of the div (namely, the "press enter to edit and esc to exit" string).
This fixes the underlying a11y issue which unblocks axe and fixes the regression.
Supersedes: #52968
Original issue: #52136
Side note: my editor rearranged the order of imports. Hope that's all right but can revert if people don't like it.
Checklist
For maintainers