-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Anomaly Detection: Fix jobs list default refresh. #57086
[ML] Anomaly Detection: Fix jobs list default refresh. #57086
Conversation
Pinging @elastic/ml-ui (:ml) |
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/single_metric_job·ts.machine learning anomaly detection single metric job creation displays the created job in the job listStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/machine_learning/anomaly_detection/single_metric_job·ts.machine learning anomaly detection single metric job creation displays the created job in the job listStandard Out
Stack Trace
To update your PR or re-run it, just comment with: |
} else { | ||
this.setRefreshInterval(value); | ||
componentDidUpdate(prevProps) { | ||
if (prevProps.lastRefresh !== this.props.lastRefresh && this.props.blockRefresh === false) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as blockRefresh
is optional, should this check be for !== true
?
do we want to treat a non-existing blockRefresh
as being a false condition? if that makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I open the page with a refresh interval set in the URL, such as |
…eshInterval when loading jobs list.
@peteharverson Hopefully fixed with 4212c9e. We were retaining the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM ⚡️
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested latest edits and LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* [ML] Fix anomaly detection jobs list default refresh. * [ML] Fix initial load of jobs list. * [ML] Fix blockRefresh check. * [ML] Fix blockRefresh check. * [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list.
* [ML] Fix anomaly detection jobs list default refresh. * [ML] Fix initial load of jobs list. * [ML] Fix blockRefresh check. * [ML] Fix blockRefresh check. * [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list. Co-authored-by: Walter Rafelsberger <[email protected]>
* [ML] Fix anomaly detection jobs list default refresh. * [ML] Fix initial load of jobs list. * [ML] Fix blockRefresh check. * [ML] Fix blockRefresh check. * [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list.
* [ML] Fix anomaly detection jobs list default refresh. * [ML] Fix initial load of jobs list. * [ML] Fix blockRefresh check. * [ML] Fix blockRefresh check. * [ML] Fix passing globalState between main tabs and retain custom refreshInterval when loading jobs list. Co-authored-by: Walter Rafelsberger <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
Fixes #56499.
Regression introduced by #52986.
30s
refresh for the anomaly detection jobs list if no other refresh is already set.lastRefresh
pattern we use on other pages: The route level component subscribes to date picker updates and passes on thelastRefresh
timestamp.blockRefresh
is now also managed on the router level and passed on as a prop.Checklist
Delete any items that are not applicable to this PR.
For maintainers