-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Unify Histograms loading states #55961
[SIEM] Unify Histograms loading states #55961
Conversation
Pinging @elastic/siem (Team:SIEM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out, tested locally and performed code review. Thanks for these last few design fixes @patrykkopycinski -- they really clean up the app experience 🙂
LGTM 👍🚀💪
One thing to note, in testing I had an instance where the cursor was stuck as the cursor: default
. Not sure if this is on master
, but I wasn't able to reproduce either here or there, so we may want to keep any eye out for this in testing.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Summary
Implements #55585
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers