Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Unify Histograms loading states #55961

Conversation

patrykkopycinski
Copy link
Contributor

Summary

Implements #55585

  • Improve loading states
  • Correct color usage

Kibana

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 v7.7.0 v7.6.0 labels Jan 26, 2020
@patrykkopycinski patrykkopycinski self-assigned this Jan 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski patrykkopycinski added the release_note:skip Skip the PR/issue when compiling release notes label Jan 26, 2020
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally and performed code review. Thanks for these last few design fixes @patrykkopycinski -- they really clean up the app experience 🙂

LGTM 👍🚀💪

One thing to note, in testing I had an instance where the cursor was stuck as the cursor: default. Not sure if this is on master, but I wasn't able to reproduce either here or there, so we may want to keep any eye out for this in testing.

Cursor stuck as `cursor: default`

Note: Cursor was stuck for all button components, not just inspect as shown below:

pointer_all_the_times

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants