-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Detections bugs rules #55885
Merged
Merged
[SIEM] Detections bugs rules #55885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/siem (Team:SIEM) |
spong
reviewed
Jan 24, 2020
x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx
Outdated
Show resolved
Hide resolved
spong
reviewed
Jan 24, 2020
spong
reviewed
Jan 24, 2020
x-pack/legacy/plugins/siem/public/pages/detection_engine/detection_engine.tsx
Show resolved
Hide resolved
spong
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed client-code and checked out and tested locally and LGTM! Thanks for all the bug and perf fixes @XavierM!
…nts_viewer.tsx Co-Authored-By: Garrett Spong <[email protected]>
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 24, 2020
* Fix flow of all rules * fix the multitude http request + fix table timeline re-rendering * Update x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx Co-Authored-By: Garrett Spong <[email protected]> Co-authored-by: Garrett Spong <[email protected]>
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jan 24, 2020
* Fix flow of all rules * fix the multitude http request + fix table timeline re-rendering * Update x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx Co-Authored-By: Garrett Spong <[email protected]> Co-authored-by: Garrett Spong <[email protected]>
XavierM
added a commit
that referenced
this pull request
Jan 25, 2020
* Fix flow of all rules * fix the multitude http request + fix table timeline re-rendering * Update x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx Co-Authored-By: Garrett Spong <[email protected]> Co-authored-by: Garrett Spong <[email protected]> Co-authored-by: Garrett Spong <[email protected]>
XavierM
added a commit
that referenced
this pull request
Jan 25, 2020
* [SIEM] Detections bugs rules (#55885) * Fix flow of all rules * fix the multitude http request + fix table timeline re-rendering * Update x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx Co-Authored-By: Garrett Spong <[email protected]> Co-authored-by: Garrett Spong <[email protected]> * fix i18n Co-authored-by: Garrett Spong <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately