-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Uptime] In Ping histogram use auto date histogram #55605
[Uptime] In Ping histogram use auto date histogram #55605
Conversation
Pinging @elastic/uptime (Team:uptime) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code looks great and I love the refactor. I'm also reminded of one of the issues we faced when leveraging ADH in the past; when we computed the interval ourselves it was easier to end up with an appropriate number of buckets for the domain.
At the same time, it's nice to see the increased detail where before we'd only have one bucket, so maybe this is actually a win. Thoughts @andrewvc?
@elasticmachine merge upstream |
@justinkambic the increased detail is actually nice IMHO in that example. |
@elasticmachine merge upstream |
The longer I've mulled it over the more I feel it's nice as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…zad31/kibana into fix/use-auto-date-histogram
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* update ping histogram API * update test * fix tests * update test * unused code Co-authored-by: Elastic Machine <[email protected]>
* update ping histogram API * update test * fix tests * update test * unused code Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
* update ping histogram API * update test * fix tests * update test * unused code Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
Fixes: #53991
Using auto date histogram to create ping histogram.
Also converted the API to Rest-API.
Sorry PR looks big, but it's not.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers