Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Uptime] In Ping histogram use auto date histogram #55605

Merged
merged 8 commits into from
Jan 30, 2020

Conversation

shahzad31
Copy link
Contributor

@shahzad31 shahzad31 commented Jan 22, 2020

Summary

Fixes: #53991
Using auto date histogram to create ping histogram.
Also converted the API to Rest-API.

Sorry PR looks big, but it's not.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@shahzad31 shahzad31 added WIP Work in progress release_note:fix v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.7.0 v7.6.0 labels Jan 22, 2020
@shahzad31 shahzad31 self-assigned this Jan 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 removed the WIP Work in progress label Jan 23, 2020
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code looks great and I love the refactor. I'm also reminded of one of the issues we faced when leveraging ADH in the past; when we computed the interval ourselves it was easier to end up with an appropriate number of buckets for the domain.

At the same time, it's nice to see the increased detail where before we'd only have one bucket, so maybe this is actually a win. Thoughts @andrewvc?

image

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@andrewvc
Copy link
Contributor

@justinkambic the increased detail is actually nice IMHO in that example.

@shahzad31
Copy link
Contributor Author

@elasticmachine merge upstream

@justinkambic
Copy link
Contributor

the increased detail is actually nice IMHO in that example.

The longer I've mulled it over the more I feel it's nice as well.

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

shahzad31 added a commit to shahzad31/kibana that referenced this pull request Jan 30, 2020
* update ping histogram API

* update test

* fix tests

* update test

* unused code

Co-authored-by: Elastic Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Jan 30, 2020
* update ping histogram API

* update test

* fix tests

* update test

* unused code

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
shahzad31 added a commit that referenced this pull request Jan 30, 2020
* update ping histogram API

* update test

* fix tests

* update test

* unused code

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:fix Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uptime some time intervals are throwing an illegal argument exception
5 participants