Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Rename geo_tile display points option to clusters #54973

Merged
merged 2 commits into from
Jan 16, 2020

Conversation

thomasneirynck
Copy link
Contributor

They're totally clusters.

image

@thomasneirynck thomasneirynck requested a review from a team as a code owner January 15, 2020 21:49
@thomasneirynck thomasneirynck added chore release_note:skip Skip the PR/issue when compiling release notes [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v7.7.0 v8.0.0 labels Jan 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better wording and with labels should help clear aggregations up a bunch. Be sure to update the docs, https://github.com/elastic/kibana/blob/master/docs/maps/maps-aggregations.asciidoc and in the getting started docs https://github.com/elastic/kibana/blob/master/docs/maps/maps-getting-started.asciidoc

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! much better name.

@nickpeihl
Copy link
Member

do we have to request new translations for localized values in x-pack/build/plugin/kibana/x-pack/plugins/translations/translations/*.json or does that happen automatically?

Copy link
Member

@jsanz jsanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, clusters is a much clear

Copy link

@alexfrancoeur alexfrancoeur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't have a chance to pull down the PR, but +1 on the name change.

@thomasneirynck thomasneirynck requested a review from nreese January 16, 2020 15:06
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
thanks for updating the docs

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck
Copy link
Contributor Author

@nickpeihl these changes are automatically picked up and will get new translations

thomasneirynck added a commit that referenced this pull request Jan 16, 2020
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants