-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Rename geo_tile display points option to clusters #54973
[Maps] Rename geo_tile display points option to clusters #54973
Conversation
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is much better wording and with labels should help clear aggregations up a bunch. Be sure to update the docs, https://github.com/elastic/kibana/blob/master/docs/maps/maps-aggregations.asciidoc and in the getting started docs https://github.com/elastic/kibana/blob/master/docs/maps/maps-getting-started.asciidoc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! much better name.
do we have to request new translations for localized values in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, clusters
is a much clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have a chance to pull down the PR, but +1 on the name change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks for updating the docs
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
@nickpeihl these changes are automatically picked up and will get new translations |
…5070) Co-authored-by: Elastic Machine <[email protected]>
They're totally clusters.