[SearchProfiler] Remove sources of recursion over potentially deeply nested objects #54015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed recursive normalizeTimes functions (one fewer iteration through the entire data structure) Optimizied appliation of tree mutations by taking `if` out of tight loop Cleaned up types
jloleysens
added
v8.0.0
Team:Kibana Management
|
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
liza-mae
suggested changes
Jan 8, 2020
There was a problem hiding this comment.
Thanks @jloleysens for getting a fix for this issue so quickly! That's great! I tested your PR and looks like 'ConstantScoreQuery' is now working properly, however I am still seeing the issue with 'DocValuesFieldExistsQuery' field. I will attach a screenshot.
|
Seems like the field highlighted in below screenshot is still throwing a RangeError: Maximum call stack size exceeded.
|
|
@elasticmachine merge upstream |
jloleysens
changed the title
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
liza-mae
approved these changes
Jan 9, 2020
There was a problem hiding this comment.
@jloleysens I tested the latest commit and looks like all is passing now :) Yay!
jloleysens
changed the title
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 10, 2020
…nested objects (elastic#54015) * Added max tree depth guard Removed recursive normalizeTimes functions (one fewer iteration through the entire data structure) Optimizied appliation of tree mutations by taking `if` out of tight loop Cleaned up types * Tidy up data being passed into store (and through immer) * Fix max tree depth logic * Remove immer from non-test code. Co-authored-by: Elastic Machine <[email protected]>
jloleysens
added a commit
that referenced
this pull request
Jan 10, 2020
…nested objects (#54015) (#54431) * Added max tree depth guard Removed recursive normalizeTimes functions (one fewer iteration through the entire data structure) Optimizied appliation of tree mutations by taking `if` out of tight loop Cleaned up types * Tidy up data being passed into store (and through immer) * Fix max tree depth logic * Remove immer from non-test code. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses this issue: #53989.
Please Note
Was not able to repro (yet), butfound some areas that could be improved and risk of exceeding stack limits reduced (see steps taken).In the original issue it looks like the stack limit is being exceeded due to a very large object being passed into
immer. Because this is happening whenView Detailsis being clicked it is most probably happening inside of thereducer.ts's use ofproduce.Steps taken
x-pack/legacy/plugins/searchprofiler/public/np_ready/application/components/profile_tree/shard_details/shard_details_tree_node.tsx).Pass only required objects toRemoved use ofproducein the store (e.g., remove thechildrenproperty)immerin non test code. Unfortunately the optimisations I proposed were not sufficiently addressing the issue :cInvestigation
After meeting with @liza-mae and seeing the issue on her machine after the initial round of optimisations to deep object traversal (results of
breakdownattribute coming from ES when profiling and theparentfield we create), some of the "View Details" actions that were not working before were working, but the deeper elements still exceeded call stack limits. Because of thisimmerhas been removed.