Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Visualizations] Add default filename when exporting CSV #54003

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

majagrubic
Copy link
Contributor

@majagrubic majagrubic commented Jan 6, 2020

….if visualization hasn't been saved

Summary

Fixes: #53960

When exporting a visualization, filename defaults to a visualization name. If visualization hasn't been saved previously, a file with an empty filename was exported, which led to confusing and erroneous behavior.

This PR introduces default (unsaved) filename, if visualization hasn't been saved previously.

Before:
Screenshot 2020-01-06 at 10 11 11

After:
Screenshot 2020-01-06 at 10 20 26

Tested in Firefox and Chrome.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@majagrubic majagrubic added v7.6.0 v8.0.0 release_note:fix Feature:Visualizations Generic visualization features (in case no more specific feature label is available) labels Jan 6, 2020
@majagrubic majagrubic changed the title [Visualization] Add default filename when exporting CSV [Visualizations] Add default filename when exporting CSV Jan 6, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@majagrubic majagrubic requested a review from a team January 6, 2020 11:48
@majagrubic majagrubic added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jan 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great little improvement!

@majagrubic
Copy link
Contributor Author

thanks @myasonik 🙇‍♀

@majagrubic majagrubic merged commit 8751e7c into elastic:master Jan 6, 2020
@majagrubic majagrubic deleted the add-empty-vis-name branch January 6, 2020 19:37
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Jan 6, 2020
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Jan 6, 2020
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download csv in visualize app is missing the viz names.
4 participants