Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename kbn_vislib_vis_types plugin #53536

Merged
merged 29 commits into from
Jan 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
7b892cc
Initial shim of kbn_vislib_vis_types
nickofthyme Dec 18, 2019
ab037a5
Move vislib into kbn_vislib_vis_types plugin
nickofthyme Dec 19, 2019
166665f
Fix import errors in test files
nickofthyme Dec 19, 2019
de9ef60
Fix dashboard style issue
nickofthyme Dec 19, 2019
8775808
Fix Internationalization check
nickofthyme Dec 19, 2019
73713fa
Fix jest test
nickofthyme Dec 20, 2019
26d6fc0
Merge branch 'master' into kpm/kbn_vislib_vis_types
nickofthyme Dec 20, 2019
17c667b
Convert remaining plugin files to typescript
nickofthyme Dec 20, 2019
e21c52e
Fix mappedColors import
nickofthyme Dec 20, 2019
e11a761
Move ui/ and plugins/ services and imports to legacy file
nickofthyme Dec 20, 2019
b416b5e
Remove none type changes
nickofthyme Dec 20, 2019
73195f9
Merge branch 'master' into kpm/kbn_vislib_vis_types
nickofthyme Dec 20, 2019
216365e
Fix jest mock imports
nickofthyme Dec 21, 2019
607242c
remove unnecessary persisted_state imports
nickofthyme Dec 21, 2019
dc1668d
Remove angular dependency from vislib tooltip and move into __Legacy
nickofthyme Dec 27, 2019
d58a943
Merge branch 'master' into kpm/kbn_vislib_vis_types
nickofthyme Dec 27, 2019
f94e179
Fix linting errors
nickofthyme Dec 27, 2019
2d383d3
Fix linting errors
nickofthyme Dec 27, 2019
ba6eea9
Update jest snapshots
nickofthyme Dec 27, 2019
ec8b095
Migrate remaining stateful deps to top-level
nickofthyme Jan 2, 2020
e918df2
Fix broken vislib mocha tests after removing Private instance
nickofthyme Jan 2, 2020
48f4958
Merge branch 'master' into kpm/kbn_vislib_vis_types
nickofthyme Jan 2, 2020
e605747
Merge branch 'master' into kpm/kbn_vislib_vis_types
elasticmachine Jan 6, 2020
a0a721e
Update .sass-lint.yml
nickofthyme Jan 9, 2020
e03d81c
address pr comments
nickofthyme Jan 10, 2020
d54759b
Rename vis to vis_type_vislib
nickofthyme Jan 10, 2020
790c9bc
Merge branch 'master' into kpm/kbn_vislib_vis_types
elasticmachine Jan 10, 2020
0f7dca3
Merge branch 'master' into kpm/kbn_vislib_vis_types
nickofthyme Jan 13, 2020
232d7b3
Merge branch 'master' into kpm/kbn_vislib_vis_types
nickofthyme Jan 15, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ bower_components
/built_assets
/html_docs
/src/plugins/data/common/es_query/kuery/ast/_generated_/**
/src/fixtures/vislib/mock_data
src/legacy/core_plugins/vis_type_vislib/public/vislib/__tests__/lib/fixtures/mock_data
/src/legacy/ui/public/angular-bootstrap
/src/legacy/ui/public/flot-charts
/test/fixtures/scenarios
Expand Down
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ module.exports = {
},
},
{
files: ['src/legacy/core_plugins/kbn_vislib_vis_types/**/*.{js,ts,tsx}'],
files: ['src/legacy/core_plugins/vis_type_vislib/**/*.{js,ts,tsx}'],
rules: {
'react-hooks/exhaustive-deps': 'off',
},
Expand Down
2 changes: 1 addition & 1 deletion .i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"interpreter": "src/legacy/core_plugins/interpreter",
"kbn": "src/legacy/core_plugins/kibana",
"kbnDocViews": "src/legacy/core_plugins/kbn_doc_views",
"kbnVislibVisTypes": "src/legacy/core_plugins/kbn_vislib_vis_types",
"kbnVislibVisTypes": "src/legacy/core_plugins/vis_type_vislib",
"management": ["src/legacy/core_plugins/management", "src/plugins/management"],
"kibana_react": "src/legacy/core_plugins/kibana_react",
"kibana-react": "src/plugins/kibana_react",
Expand Down
2 changes: 1 addition & 1 deletion .sass-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ files:
include:
- 'src/legacy/core_plugins/metrics/**/*.s+(a|c)ss'
- 'src/legacy/core_plugins/timelion/**/*.s+(a|c)ss'
- 'src/legacy/ui/public/vislib/**/*.s+(a|c)ss'
- 'src/legacy/core_plugins/vis_type_vislib/**/*.s+(a|c)ss'
- 'x-pack/legacy/plugins/rollup/**/*.s+(a|c)ss'
- 'x-pack/legacy/plugins/security/**/*.s+(a|c)ss'
- 'x-pack/legacy/plugins/canvas/**/*.s+(a|c)ss'
Expand Down
2 changes: 1 addition & 1 deletion src/dev/precommit_hook/casing_check_config.js
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ export const TEMPORARILY_IGNORED_PATHS = [
'src/legacy/core_plugins/timelion/server/series_functions/__tests__/fixtures/seriesList.js',
'src/legacy/core_plugins/timelion/server/series_functions/__tests__/fixtures/tlConfig.js',
'src/fixtures/config_upgrade_from_4.0.0_to_4.0.1-snapshot.json',
'src/fixtures/vislib/mock_data/terms/_seriesMultiple.js',
'src/legacy/core_plugins/vis_type_vislib/public/vislib/__tests__/lib/fixtures/mock_data/terms/_seriesMultiple.js',
'src/legacy/ui/public/angular-bootstrap/bindHtml/bindHtml.js',
'src/legacy/ui/public/angular-bootstrap/tooltip/tooltip-html-unsafe-popup.html',
'src/legacy/ui/public/angular-bootstrap/tooltip/tooltip-popup.html',
Expand Down
4 changes: 0 additions & 4 deletions src/legacy/core_plugins/kbn_vislib_vis_types/package.json

This file was deleted.

140 changes: 0 additions & 140 deletions src/legacy/core_plugins/kbn_vislib_vis_types/public/controller.js

This file was deleted.

50 changes: 0 additions & 50 deletions src/legacy/core_plugins/kbn_vislib_vis_types/public/gauge.d.ts

This file was deleted.

36 changes: 0 additions & 36 deletions src/legacy/core_plugins/kbn_vislib_vis_types/public/heatmap.d.ts

This file was deleted.

This file was deleted.

3 changes: 3 additions & 0 deletions src/legacy/core_plugins/kibana/public/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
// Public UI styles
@import 'src/legacy/ui/public/index';

// vis_type_vislib UI styles
@import 'src/legacy/core_plugins/vis_type_vislib/public/index';

// Dev tools styles
@import './dev_tools/index';

Expand Down
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/kibana/public/kibana.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ import './visualize';
import './dashboard';
import './management';
import './dev_tools';
import 'ui/vislib';
import 'ui/color_maps';
import 'ui/agg_response';
import 'ui/agg_types';
import { showAppRedirectNotification } from 'ui/notify';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import _ from 'lodash';
import d3 from 'd3';
import { i18n } from '@kbn/i18n';
import { KibanaMapLayer } from 'ui/vis/map/kibana_map_layer';
import { truncatedColorMaps } from 'ui/vislib/components/color/truncated_colormaps';
import { truncatedColorMaps } from 'ui/color_maps';
import * as topojson from 'topojson-client';
import { toastNotifications } from 'ui/notify';
import * as colorUtil from 'ui/vis/map/color_util';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ import {
NumberInputOption,
SelectOption,
SwitchOption,
} from '../../../kbn_vislib_vis_types/public/components';
} from '../../../vis_type_vislib/public/components';
import { WmsOptions } from '../../../tile_map/public/components/wms_options';
import { RegionMapVisParams } from '../types';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import React from 'react';
import { i18n } from '@kbn/i18n';
import { Schemas } from 'ui/vis/editors/default/schemas';
import { colorSchemas } from 'ui/vislib/components/color/truncated_colormaps';
import { truncatedColorSchemas as colorSchemas } from 'ui/color_maps';
import { mapToLayerWithId } from './util';
import { createRegionMapVisualization } from './region_map_visualization';
import { Status } from '../../visualizations/public';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@

import { i18n } from '@kbn/i18n';
import ChoroplethLayer from './choropleth_layer';
import { truncatedColorMaps } from 'ui/vislib/components/color/truncated_colormaps';
import { truncatedColorMaps } from 'ui/color_maps';
import { getFormat } from 'ui/visualize/loader/pipeline_helpers/utilities';
import { toastNotifications } from 'ui/notify';

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import {
RangeOption,
SelectOption,
SwitchOption,
} from '../../../kbn_vislib_vis_types/public/components';
} from '../../../vis_type_vislib/public/components';
import { WmsOptions } from './wms_options';
import { TileMapVisParams } from '../types';
import { MapTypes } from '../map_types';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import React from 'react';
import { EuiLink, EuiSpacer, EuiText, EuiScreenReaderOnly } from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';

import { TextInputOption } from '../../../kbn_vislib_vis_types/public/components';
import { TextInputOption } from '../../../vis_type_vislib/public/components';
import { WMSOptions } from '../types';

interface WmsInternalOptions {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
import { TmsLayer } from 'ui/vis/map/service_settings';
import { Vis } from 'ui/vis';
import { RegionMapVisParams } from '../../../region_map/public/types';
import { SelectOption, SwitchOption } from '../../../kbn_vislib_vis_types/public/components';
import { SelectOption, SwitchOption } from '../../../vis_type_vislib/public/components';
import { WmsInternalOptions } from './wms_internal_options';
import { WMSOptions, TileMapVisParams } from '../types';

Expand Down
Loading