Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve "Browser client is out of date" error message #50296

Merged
merged 5 commits into from
Nov 16, 2019
Merged

Improve "Browser client is out of date" error message #50296

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a843f2
improve "Browser client is out of date" error message
sorenlouv Nov 12, 2019
19a7520
Improve wording of error message
sorenlouv Nov 12, 2019
06bac1e
Merge branch 'master' into improve-error-message-for-kbn-version-mist…
elasticmachine Nov 14, 2019
016d699
Fox formatting
sorenlouv Nov 16, 2019
d04f6cd
Fix format
sorenlouv Nov 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
improve "Browser client is out of date" error message
  • Loading branch information
@sorenlouv
sorenlouv authored Nov 12, 2019
commit 3a843f2ef50f4e9fcff47f48ae1689cd0a90b186
11 changes: 7 additions & 4 deletions src/legacy/server/http/version_check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,13 @@ export function setupVersionCheck(server, config) {
const versionRequested = req.headers[versionHeader];

if (versionRequested && versionRequested !== actualVersion) {
throw badRequest('Browser client is out of date, please refresh the page', {
expected: actualVersion,
got: versionRequested
});
throw badRequest(
`Browser client is out of date, please refresh the page (Header "${versionHeader}" was ${versionRequested} but should be ${actualVersion})`,
{
expected: actualVersion,
got: versionRequested,
}
);
}

return h.continue;
Expand Down