[Maps] fix removal of multi fields for tooltip field selection #49816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
💔 Build Failed |
|
retest |
💚 Build Succeeded |
thomasneirynck
approved these changes
Oct 31, 2019
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 31, 2019
nreese
added a commit
that referenced
this pull request
Oct 31, 2019
|
Thanks @nreese , sorry I got it mixed up |
No problem. There were no tests so it was easy to do. Great to nested object support in KQL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #47070 changed the structure of
Field.subTypefrom a string to an object. The PR updated the logic ingetSourceFieldsbut changed the logic from filtering out multi fields to only including multi fields.This PR just fixes the logic of
getSourceFieldsand adds some tests so its clearer what the function is doingTo test, create a layer from ES documents source for web logs sample data set. Verify that all keyword fields are not included in the tooltip selection list