Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for log rotation #49750

Merged
merged 100 commits into from
Dec 10, 2019
Merged

Adds support for log rotation #49750

merged 100 commits into from
Dec 10, 2019

Conversation

mistic
Copy link
Member

@mistic mistic commented Oct 30, 2019 •
edited
Loading

That closes #12259

It ships Kibana with an included solution to do log rotation.
We decide to move quickly on this due to a need from Cloud team.

mistic added 18 commits October 7, 2019 21:23
@mistic
chore(NA): add log options to config yml
17555a3
@mistic
chore(NA): remove unwanted option from config declaration
a5a06d0
@mistic
chore(NA): add the bootstrap for the logging rotate feature
3f56e58
@mistic
Merge remote-tracking branch 'upstream/master' into log-rotation
cc0d404
@mistic
feat(NA): base interface setup for log rotation feature
a87c080
@mistic
docs(NA): add documentation for the new logging rotate options. chore…
7c739d4 
…(NA): added new schema validations
@mistic
chore(NA): base lifecycle methods and logic
057f997
@mistic
feat(NA): monitor logic for log rotate feature
ecd5436
@mistic
fix(NA): basic log rotation lifecycle
0a0dd4a
@mistic
chore(NA): fix typo on config file
75d2ffa
@mistic
feat(NA): add rotate files feature to log rotator
29779b9
@mistic
chore(NA): fix log rotate config
73cc678
@mistic
chore(NA): some tests to try logging rotate lifecycle
59e7cca
@mistic
feat(NA): correct log rotation logic
e41335b
@mistic
fix(NA): lifecycle for the log rotator
08285f5
@mistic
test(NA): add a test case
efb64aa
@mistic
Merge remote-tracking branch 'upstream/master' into log-rotation
6c6010f
@mistic
chore(NA): correctly add the new defaults to the config schema
5b8b46a
@mistic mistic added Team:Operations Team label for Operations Team release_note:roadmap Feature:New Feature New feature not correlating to an existing feature label v8.0.0 v7.6.0 labels Oct 30, 2019
@mistic mistic requested a review from a team as a code owner October 30, 2019 15:47
@mistic mistic self-assigned this Oct 30, 2019
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
@elasticmachine

This comment has been minimized.

Sign in to view
mshustov
mshustov approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires some minor cleanup, but 👌 Thanks :shipit:

@tylersmalley
Copy link
Contributor

Taking another pass at this now.

@mistic
Copy link
Member Author

mistic commented Dec 7, 2019

@tylersmalley just cleared all the feedback. I think that is ready to be merged unless you found some other problem or you have extra feedback 😄

@mistic

This comment has been minimized.

Sign in to view
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 6d5c8ca into elastic:master Dec 10, 2019
@mistic
Copy link
Member Author

mistic commented Dec 10, 2019 •
edited
Loading

7.x: 26cba4e

@mistic mistic mentioned this pull request Dec 10, 2019
Merged
@gchaps gchaps mentioned this pull request Dec 20, 2019
Closed
@mshustov mshustov mentioned this pull request Jan 29, 2020
Closed
@rudolf rudolf mentioned this pull request Mar 25, 2020
Closed
@mshustov mshustov mentioned this pull request Dec 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylersmalley tylersmalley tylersmalley approved these changes

@mshustov mshustov mshustov approved these changes

Assignees

@mistic mistic

Labels
Feature:New Feature New feature not correlating to an existing feature label Team:Operations Team label for Operations Team v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for log rotation
4 participants
@mistic @elasticmachine @tylersmalley @mshustov