Upgrade EUI to v14.9.0 #49678
Merged
Upgrade EUI to v14.9.0 #49678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thompsongl
added
v8.0.0
release_note:skip
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
chandlerprall
approved these changes
Oct 30, 2019
legrego
reviewed
Oct 31, 2019
.../legacy/plugins/spaces/public/views/management/edit_space/enabled_features/feature_table.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
myasonik
reviewed
Nov 12, 2019
.../legacy/plugins/spaces/public/views/management/edit_space/enabled_features/feature_table.tsx
Outdated
Show resolved
Hide resolved
myasonik
approved these changes
Nov 12, 2019
| @@ -59,6 +59,8 @@ export const JobSwitch = React.memo<JobSwitchProps>( | |||
| setIsLoading(true); | |||
| onJobStateChange(job, job.latestTimestampMs || 0, e.target.checked); | |||
| }} | |||
| showLabel={false} | |||
| label="" // TODO: Add label for a11y | |||
There was a problem hiding this comment.
Flagging this TODO as something to be resolved before merge
| @@ -247,6 +247,8 @@ export const JobSettingsForm: FC<JobSettingsFormProps> = ({ | |||
| useDedicatedIndex: checked, | |||
| }); | |||
| }} | |||
| showLabel={false} | |||
| label="" // TODO: Add label for a11y | |||
There was a problem hiding this comment.
Flagging this TODO as something to be resolved before merge
| @@ -43,6 +43,8 @@ export const SparseDataSwitch: FC = () => { | |||
| checked={sparseData} | |||
| onChange={toggleSparseData} | |||
| data-test-subj="mlJobWizardSwitchSparseData" | |||
| showLabel={false} | |||
| label="" // TODO: Add label for a11y | |||
There was a problem hiding this comment.
Flagging this TODO as something to be resolved before merge
| @@ -29,6 +29,8 @@ export const ModelPlotSwitch: FC = () => { | |||
| checked={modelPlotEnabled} | |||
| onChange={toggleModelPlot} | |||
| data-test-subj="mlJobWizardSwitchModelPlot" | |||
| showLabel={false} | |||
| label="" // TODO: Add label for a11y | |||
There was a problem hiding this comment.
Flagging this TODO as something to be resolved before merge
| @@ -29,6 +29,8 @@ export const DedicatedIndexSwitch: FC = () => { | |||
| checked={useDedicatedIndex} | |||
| onChange={toggleModelPlot} | |||
| data-test-subj="mlJobWizardSwitchUseDedicatedIndex" | |||
| showLabel={false} | |||
| label="" // TODO: Add label for a11y | |||
There was a problem hiding this comment.
Flagging this TODO as something to be resolved before merge
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
thompsongl
added a commit
to thompsongl/kibana
that referenced
this pull request
Nov 13, 2019
* eui to 14.9.0 * euiswitch updtates * misc snapshot * x-pack functional fixes * more euiswitch functional test fixes * label-less switches for spaces management * more euiswitch fixes * telemetry form a11y * snapshot update * label updates * more switch updates * lint
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits) [Rollup] Fix for clone job workflow (elastic#50501) Empty message "No data available" for Labels and User metadata sections missing (elastic#49846) [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315) Remove react references from core `Notifications` apis (elastic#49573) Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic [Metrics UI] Calculate interval based on the dataset's period (elastic#50194) chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610) [Telemetry] change of optin status telemetry (elastic#50158) [SIEM][Detection Engine] REST API Additions (elastic#50514) [DOCS] Removes dashboard-only mode doc (elastic#50441) [Filters] Fix operator overflowing out popover (elastic#50030) Change telemetry optIn to default to true (elastic#50490) [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169) Allow registered applications to hide Kibana chrome (elastic#49795) Upgrade EUI to v14.9.0 (elastic#49678) [Metrics UI] Convert layouts to use React components (elastic#49134) [Search service] Add support for ES request preference (elastic#49424) [Newsfeed/Lint] fix chained fn lint (elastic#50515) [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166) [SIEM] Events viewer fixes (elastic#50175) ...
thompsongl
added a commit
that referenced
this pull request
Nov 14, 2019
* eui to 14.9.0 * euiswitch updtates * misc snapshot * x-pack functional fixes * more euiswitch functional test fixes * label-less switches for spaces management * more euiswitch fixes * telemetry form a11y * snapshot update * label updates * more switch updates * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade EUI from
14.8.0to14.9.0EuiSwitchmakes up most of the noise here. It changed from being aninputto abuttonwith a shimmed event. This was done for accessibility reasons, and should be generally unnoticeable to users. Functional test eventing, however, required quite a few updates.14.9.0euiTreeViewcomponent for rendering recursive objects such as folder structures. (#2409)euiXScrollWithShadows()mixin and.eui-xScrollWithShadowsutility class (#2458)EuiColorStopswhere empty string values would cause range min or max to be NaN (#2496)EuiSwitcha11y by aligning to aria roles (#2491)EuiSwitchto TypeScript (#2491)EuiSwitchvariation (#2491)Bug fixes
moz-focus-inner(#2445)aria-modalattribute inEuiPopover(#2488)EuiCodeBlockcontrols and added more tests (#2459)EuiCodeBlockso thatoverflowHeightnow applies amaxHeightinstead of aheighton the block (#2487)EuiSwitchform behavior by adding a default buttontypeof 'button' (#2491)