Fix angular stack overflow by changing apply filters popover directiv…

[lizozom]

Summary

Fix angular stack overflow on dashboard application, by changing apply filters popover directive implementation

The bug was caused by a combination of now passing in the notification service into IndexPatterns and the custom way that the applyFiltersPopover directive used to watch filters and modify state in it.

This PR changes the way applyFiltersPopover watches state. It also moves modifying the state into the React component.

bee4212

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

• This was checked for cross-browser compatibility, including a check against IE11
• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility

For maintainers

• This was checked for breaking API changes and was labeled appropriately
• This includes a feature addition or change that requires a release note and was labeled appropriately

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[elasticmachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 2aea7e5

[mattkime]

I'm unclear if this aims to solve all stack overflow issues or just a specific subset. I'm running the branch locally and looking at discover - adding and removing filters causes stack overflow errors.

Another action in discover which causes stack overflow - https://cl.ly/f62c957e90a8

[lizozom]

@mattkime this is specific to the errors on dashboard. Sorry for not mentioning it in the issue. Now it seems we have more than one problem!

[ppisljar]

LGTM