[Graph] Stabilize delete test #48387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Graph
💚 Build Succeeded |
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 17, 2019
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Oct 17, 2019
flash1293
added a commit
that referenced
this pull request
Oct 17, 2019
flash1293
added a commit
that referenced
this pull request
Oct 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47753
The Graph delete test was unstable because it didn't wait for the listing to re-fetch the updated list before checking whether it was empty.
This PR changes the logic to wait for the graph prompt button to show up again (happens as soon as the empty list is fetched successfully)
This is also how the visualize page handles the same test:
test/functional/page_objects/visualize_page.jsline 90