Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update geckodriver to 0.26 #48201

Merged
merged 2 commits into from
Oct 17, 2019
Merged

update geckodriver to 0.26 #48201

merged 2 commits into from
Oct 17, 2019

Conversation

dmlemeshko
Copy link
Member

New driver release 0.26 is available

0.25.0 came with a series of internal changes for how geckodriver
communicates with Firefox over the Marionette protocol. This
release contains the second half of the refactoring work.

@dmlemeshko dmlemeshko added test-firefox test-matrix Use this label to ensure PRs are tested with matrix jobs v7.4.1 v7.5.0 v8.0.0 and removed v7.4.1 v7.5.0 v8.0.0 labels Oct 15, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 15, 2019 •
edited by dmlemeshko
Loading

💔 Build Failed

2/20 workers fail due to debian 10 + FF issue, reported to infra

@dmlemeshko dmlemeshko force-pushed the bump-geckodriver-up-to-0.26 branch from a988ee6 to dce7e06 Compare October 15, 2019 16:50
@dmlemeshko dmlemeshko added v7.4.1 v7.5.0 v8.0.0 and removed test-matrix Use this label to ensure PRs are tested with matrix jobs labels Oct 15, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko requested review from spalger and a team October 15, 2019 18:31
@dmlemeshko dmlemeshko added the release_note:skip Skip the PR/issue when compiling release notes label Oct 15, 2019
@dmlemeshko dmlemeshko marked this pull request as ready for review October 15, 2019 18:31
brianseeders
brianseeders approved these changes Oct 15, 2019
View reviewed changes
Copy link
Contributor

@brianseeders brianseeders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as long as the infra changes get rolled out first

@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko merged commit bb98fd1 into elastic:master Oct 17, 2019
@dmlemeshko dmlemeshko mentioned this pull request Oct 17, 2019
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Oct 17, 2019
@dmlemeshko
update geckodriver (elastic#48201)
660f122
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Oct 17, 2019
@dmlemeshko
update geckodriver (elastic#48201)
080aea6
@dmlemeshko dmlemeshko mentioned this pull request Oct 17, 2019
Merged
dmlemeshko added a commit that referenced this pull request Oct 17, 2019
@dmlemeshko
update geckodriver (#48201) (#48493)
36accc6
dmlemeshko added a commit that referenced this pull request Oct 17, 2019
@dmlemeshko
update geckodriver (#48201) (#48494)
83ddf94
@dmlemeshko dmlemeshko deleted the bump-geckodriver-up-to-0.26 branch January 31, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianseeders brianseeders brianseeders approved these changes

@spalger spalger Awaiting requested review from spalger

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes test-firefox v7.4.1 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmlemeshko @elasticmachine @brianseeders