[Maps] clean features in locked tooltip after re-fetch #48016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
💚 Build Succeeded |
💔 Build Failed |
💚 Build Succeeded |
💚 Build Succeeded |
thomasneirynck
approved these changes
Oct 14, 2019
|
|
||
| const emsIdField = emsFileLayer._config.fields.find(field => { | ||
| return field.type === 'id'; | ||
| }); |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Oct 14, 2019
* [Maps] clean features in locked tooltip after re-fetch * fetch geometry from FEATURE_ID_PROPERTY_NAME instead of _id * set FEATURE_ID_PROPERTY_NAME for pew pew source * do not update tooltip state if no features were removed * set FEATURE_ID_PROPERTY_NAME for EMS_file source and kibana_regionmap source * avoid adding lodash to map actions * use if else instead of early return
nreese
added a commit
that referenced
this pull request
Oct 14, 2019
* [Maps] clean features in locked tooltip after re-fetch * fetch geometry from FEATURE_ID_PROPERTY_NAME instead of _id * set FEATURE_ID_PROPERTY_NAME for pew pew source * do not update tooltip state if no features were removed * set FEATURE_ID_PROPERTY_NAME for EMS_file source and kibana_regionmap source * avoid adding lodash to map actions * use if else instead of early return
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44116 and #32560
There are 2 bugs
clearTooltipStateForLayeraction was not updated to support multiple features in tooltipState back in 7.3__kbn__feature_id__changes for each re-refetch even if the underling feature is the same. This makes it impossible to map features from on dataRequest to the next dataRequest.This PR renames
clearTooltipStateForLayertocleanTooltipStateForLayerand updates the logic to support tooltipState with multiple features. The logic is also updated to keep tooltip features for a layer if they still exist in the layer.This PR updates ES documents source, ES grid source, and ES point to point source to provide consistent
__kbn__feature_id__across re-fetches for features that are the same.