Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert agg_types/__tests__ to JEST #47967

Merged
merged 2 commits into from
Oct 17, 2019
Merged

Convert agg_types/__tests__ to JEST #47967

merged 2 commits into from
Oct 17, 2019

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Oct 11, 2019 •
edited
Loading

Part of #44956

Summary

What was done it this PR:

  • Mocha tests for base classes were migrated to JEST

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp self-assigned this Oct 11, 2019
@alexwizp alexwizp added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) v7.5.0 v8.0.0 Team:AppArch labels Oct 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration labels Oct 11, 2019
@lukeelmers lukeelmers mentioned this pull request Oct 11, 2019
Closed
10 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@alexwizp
Copy link
Contributor Author

Requires changes from #47730

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexwizp alexwizp merged commit 27a9725 into elastic:master Oct 17, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Oct 17, 2019
@alexwizp
Convert agg_types/__tests__ to JEST (elastic#47967)
a77acc5
@alexwizp alexwizp mentioned this pull request Oct 17, 2019
Merged
alexwizp added a commit that referenced this pull request Oct 17, 2019
@alexwizp
Convert agg_types/__tests__ to JEST (#47967) (#48489)
2d7a1da
@alexwizp alexwizp deleted the agg_types_tests branch January 4, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@streamich streamich Awaiting requested review from streamich

@lizozom lizozom Awaiting requested review from lizozom

Assignees

@alexwizp alexwizp

Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexwizp @elasticmachine @ppisljar