Show toast after a new watcher is created #47197
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
sorenlouv
reviewed
Oct 3, 2019
| @@ -260,7 +260,8 @@ export class WatcherFlyout extends Component< | |||
| } | |||
| )}{' '} | |||
| <KibanaLink | |||
| path={`/management/elasticsearch/watcher/watches/watch/${id}`} | |||
| path={`/management/elasticsearch/watcher/watches/watch/${id}/status`} | |||
There was a problem hiding this comment.
@sqren, I changed it because the old link was going to the Watcher List Page instead of opening the watcher which has just been created. Unless that is the correct behavior?
There was a problem hiding this comment.
This looks good. Thanks for catching this 👍
sorenlouv
approved these changes
Oct 3, 2019
|
Btw. can you check if we have the same problem with machine learning (ML) integration and in that case fix it in this PR too? |
|
retest |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46454
Pass the Kibana context to KibanaLink in case it cannot get it from the KibanaCore hook.