-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nested field support to KQL #47070
Merged
Merged
Changes from 76 commits
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
497a4f9
Add nested sub type
Bargs 52dde94
Broken commit. Starting work on nested kuery function. Still needs work
Bargs dbd53e0
Merge remote-tracking branch 'upstream/master' into nested
Bargs ec7046a
Support nested `{}` syntax in KQL
Bargs cef9d4c
Basic single level nested queries working
Bargs db95789
Merge remote-tracking branch 'upstream/master' into nested
Bargs 96ad9a8
Merge remote-tracking branch 'upstream/master' into nested
Bargs 7294ad5
support fields that are both nested and multi. And support nested fields
Bargs b9056f5
Require path when querying nested fields
Bargs 7de3045
Merge remote-tracking branch 'upstream/master' into nested
Bargs d95ca51
autocomplete work
Bargs 7ed7074
Merge remote-tracking branch 'upstream/master' into nested
Bargs 02c5e23
support nested fields in the autocomplete value suggestions
Bargs af7723c
fix undefined property access error
Bargs 1708560
Support operator suggestions inside nested groups
Bargs 2a7ab3a
Merge remote-tracking branch 'upstream/master' into nested
Bargs 443df93
Improve placement of cursor after selecting autocomplete suggestions
Bargs 2c5ea5a
Merge remote-tracking branch 'upstream/master' into nested
Bargs ff67683
Merge remote-tracking branch 'upstream/master' into nested
Bargs db4ad9e
Provide helpful error messages when nested syntax is not used correctly
Bargs 376b797
only suggest actual nested fields inside a nested group. Previously this
Bargs 9e2355e
Merge remote-tracking branch 'upstream/master' into nested
Bargs 4154422
Implement nested field syntax info toast
Bargs 80f7ac6
remove comment
Bargs 9cbe1fd
Merge remote-tracking branch 'upstream/master' into nested
Bargs 59fdebe
Merge remote-tracking branch 'upstream/master' into nested
Bargs dc7a42d
fix outdated reference
Bargs 6f398c4
update expected subType format everywhere
Bargs 81b5466
Add subType and parent migration for index pattern fields
Bargs 56792d1
Merge remote-tracking branch 'upstream/master' into nested
Bargs 701eb9f
Fixes from merge conflicts
Bargs 28da930
update fixtures with new subType shape
Bargs 23307c9
Merge remote-tracking branch 'upstream/master' into nested
Bargs 8329f76
Update usage of old parent property
Bargs a0eecb0
Merge remote-tracking branch 'upstream/master' into nested
Bargs b82982b
Update tests that were written for first syntax I tried
Bargs 2740fc1
Fix geo_polygon tests
Bargs 25ab17d
update test
Bargs f134405
Harden migration, fixes spaces api integration test failures
Bargs abb0e84
Merge remote-tracking branch 'upstream/master' into nested
Bargs 2b8b4ba
comment out for now so other tests can run
Bargs dd3778c
update field_caps_response tests with nested field cases
Bargs b70c607
add tests for getFullFieldNameNode function
Bargs 75b4007
tests for the handling of nested field suggestions in the autocomplete
Bargs 52bace2
Fix so nested subfields are suggested anytime they contain the search…
Bargs 6df91e2
Merge remote-tracking branch 'upstream/master' into nested
Bargs 801b06c
add doubly nested ast test
Bargs c60b2ba
add tests for passing nested path to operator and value suggestion pr…
Bargs ad3d6f3
nested function tests
Bargs 0b52afc
Add tests for nested functionality in existing functions
Bargs d4f8ae7
Merge remote-tracking branch 'upstream/master' into nested
Bargs 6067712
Fix failures caused by buildNodeParams change
Bargs adfe6d1
Merge remote-tracking branch 'upstream/master' into nested
Bargs 163b4b9
Tests for nested auto wrapping with wildcard field names
Bargs e047e82
Add API integration test for nested field support in suggestions API
Bargs e327f67
Merge remote-tracking branch 'upstream/master' into nested
Bargs 9305b18
Fix incorrect type
Bargs ecf3994
Add simple functional test to ensure nested queries work end to end
Bargs ce1f3ef
update tests for fixture changes
Bargs 88790a7
Merge remote-tracking branch 'upstream/master' into nested
Bargs 736d994
Merge remote-tracking branch 'upstream/master' into nested
Bargs 4797092
allow for whitespace in the nested operator
Bargs e791515
use class member
Bargs 0a5bbf4
Fix bug preventing suggestions from working on index patterns with ch…
Bargs 3a715c2
Merge remote-tracking branch 'upstream/master' into nested
Bargs 9b3c63b
`:{` is no longer expected now that whitespace is allowed between the…
Bargs 9324965
Fix test with updated error message
Bargs e4dee06
Update error messages
Bargs 6285bf0
Update error message based on copy feedback
Bargs 3bb3947
add nested query syntax info to the KQL documentation
Bargs 4b589a5
Merge remote-tracking branch 'upstream/master' into nested
Bargs 74593c5
Apply suggestions from code review
Bargs 2ce8079
Improve help message copy
Bargs d34ccfd
Merge remote-tracking branch 'upstream/master' into nested
Bargs e00128a
Update docs/discover/kuery.asciidoc
Bargs 898f76a
make it clear parts of the query can match different docs, but they d…
Bargs 39ddcf8
Merge remote-tracking branch 'upstream/master' into nested
Bargs 3db6b18
updated outdated service name
Bargs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe before starting with the more complex example here, let's explain the difference to what
items:{ name:banana } and items:{ stock > 10 }
actually is. I know that the next paragraph explains that behavior, but I think it might be a bit more clear if we use exactly the same example and show how this works in the "opposite" way, before then continue on an example with a more complex query? cc @gchapsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Bargs I agree with what Tim is saying. Happy to review the updated text when it is ready.