Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves out the Export functionality in Dashboards to a new Page panel #45210

Closed
wants to merge 4 commits into from
Closed

Moves out the Export functionality in Dashboards to a new Page panel #45210

wants to merge 4 commits into from

Conversation

joelgriffith
Copy link
Contributor

Summary

In Dashboards, it can be hard for new users to find the Exporting features due to the fact that they're under the "Share" button. This PR follows guidance from #39620, and simply makes these changes in only the Dashboard app.

Right now I'm seeing how many tests this also breaks before moving onto different parts of Kibana.

@joelgriffith joelgriffith added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Sep 9, 2019
@joelgriffith
Copy link
Contributor Author

I went the route of modifying share_context_menu.tsx since it covered 90% of what needed to be done, as opposed to forking it. We'll see how well this plays out.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants