[code] Append go env variable 'GOCACHE' to go lsp spawn command. #44864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/code |
zfy0701
approved these changes
Sep 5, 2019
movie-travel-code
force-pushed
the
add_environment_gocache
branch
from
03c0162 to
a6e9a9e
Compare
💚 Build Succeeded |
💚 Build Succeeded |
Poytr1
approved these changes
Sep 5, 2019
'GOCACHE' is set to '$HOME/.cache' by default. It is not portable because it relies on the users who run the kibana. Customize 'GOCACHE' to $GOPATH/.cache to make the go lsp more portable. FYI: The build cache is now required as a step toward eliminating $GOPATH/pkg.
movie-travel-code
force-pushed
the
add_environment_gocache
branch
from
a6e9a9e to
4025fd2
Compare
💚 Build Succeeded |
movie-travel-code
pushed a commit
to movie-travel-code/kibana
that referenced
this pull request
Sep 5, 2019
…stic#44864) 'GOCACHE' is set to '$HOME/.cache' by default. It is not portable because it relies on the users who run the kibana. Customize 'GOCACHE' to $GOPATH/.cache to make the go lsp more portable. FYI: The build cache is now required as a step toward eliminating $GOPATH/pkg.
movie-travel-code
pushed a commit
to movie-travel-code/kibana
that referenced
this pull request
Sep 5, 2019
…stic#44864) 'GOCACHE' is set to '$HOME/.cache' by default. It is not portable because it relies on the users who run the kibana. Customize 'GOCACHE' to $GOPATH/.cache to make the go lsp more portable. FYI: The build cache is now required as a step toward eliminating $GOPATH/pkg.
movie-travel-code
pushed a commit
that referenced
this pull request
Sep 5, 2019
) (#44901) 'GOCACHE' is set to '$HOME/.cache' by default. It is not portable because it relies on the users who run the kibana. Customize 'GOCACHE' to $GOPATH/.cache to make the go lsp more portable. FYI: The build cache is now required as a step toward eliminating $GOPATH/pkg.
movie-travel-code
pushed a commit
that referenced
this pull request
Sep 5, 2019
) (#44902) 'GOCACHE' is set to '$HOME/.cache' by default. It is not portable because it relies on the users who run the kibana. Customize 'GOCACHE' to $GOPATH/.cache to make the go lsp more portable. FYI: The build cache is now required as a step toward eliminating $GOPATH/pkg.
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…ete-for-distance_feature * 'master' of github.com:elastic/kibana: (89 commits) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) [ML] File data viz limiting uploaded doc chunk size (elastic#44768) [code] Append go env variable 'GOCACHE' to go lsp spawn command. (elastic#44864) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
'GOCACHE' is set to '$HOME/.cache' by default. It is not portable
because it relies on the users who run the kibana. Customize
'GOCACHE' to $GOPATH/.cache to make the go lsp more portable.
FYI: The build cache is now required as a step toward eliminating
$GOPATH/pkg.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This includes a feature addition or change that requires a release note and was labeled appropriately