[ML] Data frame analytics: Split comma-separated Kibana index patterns to array of indices. #44757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
|
Pinging @elastic/ml-ui |
💔 Build Failed |
|
FYI @jgowdyelastic @peteharverson I overlooked a TypeScript error and fixed it in 982ba90, also added some tests. |
...lic/data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/state.ts
Outdated
Show resolved
Hide resolved
|
@jgowdyelastic I pushed another update after our discussion: d94beba
|
|
latest changes LGTM |
💚 Build Succeeded |
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 4, 2019
…s to array of indices. (elastic#44757) Kibana index patterns can be comma-separated whereas the create analytics API takes an array of indices. This fixes the analytics creation UI to convert Kibana index patterns to ES index patterns.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 4, 2019
…s to array of indices. (elastic#44757) Kibana index patterns can be comma-separated whereas the create analytics API takes an array of indices. This fixes the analytics creation UI to convert Kibana index patterns to ES index patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kibana index patterns can be comma-separated whereas the create analytics API takes an array of indices. This fixes the analytics creation UI to convert Kibana index patterns to ES index patterns.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11no DOM changesAny text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsFor maintainers