Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using string formatter for range aggregations. Closes #4432 & #4404 #4434

Closed
wants to merge 4 commits into from

Conversation

gauravsinghania
Copy link
Contributor

For an aggregations the field format used depends on the field type. For a number field the x-axis labels are NaN and a numberic formatter would give wrong results, hence forcing a string formatter for a range aggregations. Closes #4432 & #4404

@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@gauravsinghania
Copy link
Contributor Author

@spalger any updates?

@spalger
Copy link
Contributor

spalger commented Jul 29, 2015

Sorry @gauravsinghania I've been aggressively trying to get merged and will get to this soon

#4335

@gauravsinghania
Copy link
Contributor Author

@spalger no worries, thanks.

@spalger
Copy link
Contributor

spalger commented Aug 5, 2015

Hey @gauravsinghania, I merged master and updated the changes to match the date_range aggregation's implementation. Would you mind taking a look at my pull against your fork and merging it when you get a chance?

@gauravsinghania
Copy link
Contributor Author

@spalger thanks, I will have a look.

@spalger
Copy link
Contributor

spalger commented Aug 7, 2015

@gauravsinghania the change list looks daunting, but that's because it merges master. If you merge it into your pull request (just hit the green button) then we can move forward with this pull.

@gauravsinghania
Copy link
Contributor Author

@spalger it was delayed because so far I was using es 1.5.2 and the kibana master doesn't work with it. Is there a work around or I need to use es 2.0. Also if I have to use es 2.0 do i need to get the code or is there any binary available for it (in the repo I can only see executable till 1.7.1) .

convert format changing to match date_range
@spalger spalger mentioned this pull request Aug 8, 2015
@spalger
Copy link
Contributor

spalger commented Aug 9, 2015

@gauravsinghania, thanks so much for taking the initiative here. The more I played with this the more it inspired another approach, which I have taken in #4613. Please take a look at that pr and let me know if it works for you. For now I'm going to close this as the other PR includes these changes.

@spalger spalger closed this Aug 9, 2015
@gauravsinghania
Copy link
Contributor Author

@spalger thanks a lot. I will have a look at the other PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants