[Plugin Generator] Add integration test #43219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add yarn script.
wayneseymour
added
Team:Core
|
Pinging @elastic/kibana-platform |
💔 Build Failed |
💔 Build Failed |
After the fixups are merged, these should fail.
💔 Build Failed |
When these fail, that means the broken commands have been fixed.
💔 Build Failed |
💔 Build Failed |
and bump global timeout for this test.
💚 Build Succeeded |
not error. Add an integration test to verify the change.
💚 Build Succeeded |
…tor/integration-test
wayneseymour
changed the title
💚 Build Succeeded |
refactor the jest cli option, "higher up".
💚 Build Succeeded |
…tor/integration-test
drop needless escape char.
wayneseymour
changed the title
💚 Build Succeeded |
spalger
suggested changes
Sep 5, 2019
| @@ -78,7 +78,7 @@ module.exports = { | |||
| }, | |||
| allowSameFolder: { type: 'boolean' }, | |||
| }, | |||
| additionalProperties: false, | |||
| additionalProperties: true, | |||
There was a problem hiding this comment.
We can get rid of this right?
There was a problem hiding this comment.
That was to make yarn lint succeed, as it was failing. I'll switch it back and see what we get.
| const create = spawn(process.execPath, ['scripts/generate_plugin.js', pluginName], { | ||
| cwd: ROOT_DIR, | ||
| }); | ||
| create.stdout.on('data', () => { |
There was a problem hiding this comment.
Mind tossing a comment here to describe what's happening?
…tor/integration-test
Switch the generator to a function declaration, instead of an arrow fn, for better readability and add a comment to help as well.
💚 Build Succeeded |
…tor/integration-test
…tor/integration-test
While debugging, I noticed the `uiApps` collection contains the integration test's plugin. Also, it looks like some logic was adding the plugin's tests, again. I want this to run in ci to see if the "Test Result : Browser Unit Tests" report is back around the 500 count mark, with this logic commented out.
💔 Build Failed |
💚 Build Succeeded |
|
@spalger no...thank you! :) |
wayneseymour
added a commit
to wayneseymour/kibana
that referenced
this pull request
Sep 6, 2019
Addresses elastic#17061 ### Features Covered - generating a plugin #### Then from within the generated plugin's directory - running `yarn build` - running `yarn test:browser` - running `yarn test:server` - running `yarn start` - running `yarn preinstall` - running `yarn lint` - running `yarn kbn --help` - running `yarn es --help`
wayneseymour
added a commit
that referenced
this pull request
Sep 11, 2019
* [Plugin Generator] Add integration test (#43219) Addresses #17061 ### Features Covered - generating a plugin #### Then from within the generated plugin's directory - running `yarn build` - running `yarn test:browser` - running `yarn test:server` - running `yarn start` - running `yarn preinstall` - running `yarn lint` - running `yarn kbn --help` - running `yarn es --help` * Fixup parse error for intl file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #17061
Features Covered
Then from within the generated plugin's directory
yarn buildyarn test:browseryarn test:serveryarn startyarn preinstallyarn lintyarn kbn --helpyarn es --help