fixes scaling logic to check agg type instead schema #42574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppisljar
commented
Aug 5, 2019
| @@ -157,8 +157,8 @@ export const dateHistogramBucketAgg = new BucketAggType({ | |||
|
|
|||
| const scaleMetrics = interval.scaled && interval.scale < 1; | |||
| if (scaleMetrics && aggs) { | |||
| const all = _.every(aggs.bySchemaGroup.metrics, function (agg) { | |||
| return agg.type && agg.type.isScalable(); | |||
| const all = _.every(aggs.filter(agg => agg.type && agg.type.type === 'metric'), function (agg) { | |||
There was a problem hiding this comment.
i could use aggs.byTypeType.metric here but we want to get rid of using indexed array in aggs
💔 Build Failed |
|
Pinging @elastic/kibana-app-arch |
ppisljar
force-pushed
the
fix/dateHistogramScaling
branch
from
5afb87f to
8eb5f84
Compare
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
timroes
approved these changes
Aug 8, 2019
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 8, 2019
* fixes scaling logic to check agg type instead schema * adding selenium test * updating jest snapshot * fixing test * Change test order * Fix test order
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Aug 8, 2019
* fixes scaling logic to check agg type instead schema * adding selenium test * updating jest snapshot * fixing test * Change test order * Fix test order
timroes
pushed a commit
that referenced
this pull request
Aug 9, 2019
timroes
pushed a commit
that referenced
this pull request
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes axis scaling to only apply to specific metrics that have scaling enabled.
Fixes #42335
Release notes: axis scaling was fixed to only apply to metrics with scaling enabled.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)