[SIEM] Fixes timeline permissions for unauthorized users #41767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
Team:SIEM
v8.0.0
release_note:skip
|
Pinging @elastic/secops |
💚 Build Succeeded |
XavierM
force-pushed
the
siem-timeline-unauthorized-user
branch
from
31ed734 to
b3f2ac1
Compare
This comment has been minimized.
This comment has been minimized.
XavierM
force-pushed
the
siem-timeline-unauthorized-user
branch
from
eb58748 to
3a1efdf
Compare
andrew-goldstein
approved these changes
Jul 23, 2019
There was a problem hiding this comment.
I ran (as a proxy for the code in this branch) the 7.3-specific siem-fix-unauthorized-timeline branch against a cloud instance of 7.3 BC5, and verified the timeline behaves as expected for regular and read-only users, including the case where timelines created by the former are opened by the latter.
Thanks @XavierM for supporting the use case of read-only users! 🙏 🚀
LGTM
FrankHassanabad
approved these changes
Jul 23, 2019
XavierM
force-pushed
the
siem-timeline-unauthorized-user
branch
from
20bc9cf to
a76afbd
Compare
|
please retest this |
💚 Build Succeeded |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jul 24, 2019
* Allow error to show in the application * Allow unauthorized user to use timeline api with redux storage * add callout to timeline to show + fix event details * Build fixes * fix pinned event * review I * fix details timeline test on api integration
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jul 24, 2019
* Allow error to show in the application * Allow unauthorized user to use timeline api with redux storage * add callout to timeline to show + fix event details * Build fixes * fix pinned event * review I * fix details timeline test on api integration
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Jul 24, 2019
* Allow error to show in the application * Allow unauthorized user to use timeline api with redux storage * add callout to timeline to show + fix event details * Build fixes * fix pinned event * review I * fix details timeline test on api integration
XavierM
added a commit
that referenced
this pull request
Jul 24, 2019
* Allow error to show in the application * Allow unauthorized user to use timeline api with redux storage * add callout to timeline to show + fix event details * Build fixes * fix pinned event * review I * fix details timeline test on api integration
XavierM
added a commit
that referenced
this pull request
Jul 24, 2019
* Allow error to show in the application * Allow unauthorized user to use timeline api with redux storage * add callout to timeline to show + fix event details * Build fixes * fix pinned event * review I * fix details timeline test on api integration
XavierM
added a commit
that referenced
this pull request
Jul 24, 2019
* Allow error to show in the application * Allow unauthorized user to use timeline api with redux storage * add callout to timeline to show + fix event details * Build fixes * fix pinned event * review I * fix details timeline test on api integration
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jul 24, 2019
* upstream/7.x: Ensure visualizations in percentage mode respect the advanced settings percent format (elastic#39044) (elastic#41855) [7.x] [telemetry] Analytics Package (elastic#41113) (elastic#41774) [Uptime] Improve `useUrlParams` hook for Uptime app (elastic#41545) (elastic#41818) [Maps] refactor filter actions to use embeddable actions (elastic#41713) (elastic#41821) [Maps] clean up tooltip header and footer (elastic#41793) (elastic#41816) [SIEM] Timeline NOT working with unauthorized (elastic#41767) (elastic#41873) Use index patterns service inside data plugin (rather than importing from ui/public) (elastic#41639) (elastic#41867)
FrankHassanabad
added
release_note:fix
and removed
release_note:skip
FrankHassanabad
changed the title
💔 Build Failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If your
kibanauser does not have any privilege and you want to use the timeline in the SIEM app, you will get this page below because you are unauthorized to usesaved objects#41707
To Test
you will have to create a user with
no powerwho would follow this role belowChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately